Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marcus Bains "now" line broken in Plan and Gantt views #7892

Closed
3 of 7 tasks
charlesh88 opened this issue Oct 15, 2024 · 1 comment · Fixed by #7898
Closed
3 of 7 tasks

Marcus Bains "now" line broken in Plan and Gantt views #7892

charlesh88 opened this issue Oct 15, 2024 · 1 comment · Fixed by #7898

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Oct 15, 2024

Summary

The Marcus Bains (aka "now") line is not positioning itself properly in Time Strip, Plan and Gantt views. Note the Time Conductor settings, - 7 / +7 hours which should place the line in the middle of the Gantt area:
Screenshot 2024-10-15 at 2 26 50 PM

If a Time Strip just has a Plan in it, it won't work as noted. But if the Time Strip has telemetry in it, it will work properly:
Screenshot 2024-10-15 at 2 27 44 PM

IMO this should be a blocker as it's severely misleading for situational awareness.

Expected vs Current Behavior

Steps to Reproduce

  1. Put the Time Conductor into Real-time mode. Set the Start and End roughly the same interval.
  2. View a Plan.
  3. Observe the MB line at the very start of the Gantt area.
  4. Add a Plan view to a Gantt view. Repeat step 3.

Environment

  • Open MCT Version: 4.1.0-next 47f0b66
  • Deployment Type:
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Oct 17, 2024

Testing instructions:
Do steps 1-3 for:

  • A regular plan view (Viper Plans for example),
  • A gantt chart view and
  • A time strip view with at least one plot.
  1. Change the time conductor to use Real Time.
  2. Make sure that the now line shows up in the right place by changing the before and after offsets for the real-time window.
  3. Resize the window and ensure the now line adjusts accordingly.
  4. For a Gantt Chart or a time strip view, drag and drop a different plan into the view, accept the popup-dialog and re-test steps 1-3.

ozyx added a commit that referenced this issue Oct 17, 2024
* Initialize alignment offset to 0. (it was undefined). Also handle a small bug with swimlane configuration not getting replaced when the plan used by a gantt chart was changed

* lint: fix

* test: update visual tests to mock clock and show now line

---------

Co-authored-by: Mazzella, Jesse D. (ARC-TI)[KBR Wyle Services, LLC] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants