Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Styling] Persisted styles don't get applied to Stacked Plot Items #7338

Closed
2 of 7 tasks
ozyx opened this issue Jan 4, 2024 · 2 comments · Fixed by #7341
Closed
2 of 7 tasks

[Styling] Persisted styles don't get applied to Stacked Plot Items #7338

ozyx opened this issue Jan 4, 2024 · 2 comments · Fixed by #7341
Labels
severity:critical type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@ozyx
Copy link
Contributor

ozyx commented Jan 4, 2024 •
edited
Loading

Summary

See title. If you apply and save styles on a StackedPlotItem (such as a Plot), then reload (or navigate away and back), the styles don't get applied.

Expected vs Current Behavior

The persisted styles should apply to the stacked plot items.

Steps to Reproduce

  1. Create a Stacked Plot
  2. Create a Sine Wave Generator
  3. Drag the Sine Wave Generator into the Stacked Plot
  4. Click on the Sine Wave Generator Stacked Plot Item to select it
  5. In Edit mode, click on the "Styles" tab in the right-hand inspector.
  6. Style the item with a custom color, border, font style and font size
  7. Save and Finish Editing
  8. Reload the page
  9. No styles :(

Environment

  • Open MCT Version: 70de736
  • Deployment Type: local
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Uploading Screen Recording 2024-01-03 at 5.07.34 PM.mov…
@ozyx ozyx added the type:bug label Jan 4, 2024
@ozyx ozyx self-assigned this Jan 4, 2024
@ozyx ozyx mentioned this issue Jan 4, 2024
Merged
15 tasks
@ozyx ozyx added this to the Target:3.3.0 milestone Jan 8, 2024
@ozyx ozyx closed this as completed in #7341 Jan 8, 2024
ozyx added a commit that referenced this issue Jan 8, 2024
@ozyx
fix(#7338): Persisted styles correctly apply to StackedPlotItems on…
dfba4e2 
… mount (#7341)

* refactor: use `Plot` component directly in `StackedPlotItem` template

* test(e2e): fix style test for stackedplot

* test(e2e): add annotation back in

* test: fix unit tests

* refactor: tidy up

* fix: move const, remove eslint ignore

* fix: apply staleness styling properly

* refactor: remove unused data()

* refactor: remove unused `isMissing`

* refactor: remove debug statements
@ozyx
Copy link
Contributor Author

ozyx commented Jan 8, 2024

Testing Instructions

  • Follow steps to reproduce and verify that persisted styles apply correctly on mount

@rukmini-bose
Copy link
Contributor

Verified Testathon 1/17/2024.

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Jan 17, 2024
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(#7338): Persisted styles correctly apply to StackedPlotItems on mount nasa/openmct
3 participants
@ozyx @unlikelyzero @rukmini-bose