Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications have ProgressBar artifacts in them #7022

Closed
2 of 7 tasks
ozyx opened this issue Aug 31, 2023 · 2 comments · Fixed by #7024
Closed
2 of 7 tasks

Notifications have ProgressBar artifacts in them #7022

ozyx opened this issue Aug 31, 2023 · 2 comments · Fixed by #7024
Assignees
@ozyx
Labels
bug:regression It used to work. Now it doesn't :( type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@ozyx
Copy link
Contributor

ozyx commented Aug 31, 2023 •
edited by unlikelyzero
Loading

Summary

Notifications now have tiny ProgressBar artifacts next to the message body. This regression seems to be caused by some change introduced here: #6953

Expected vs Current Behavior

Steps to Reproduce

  1. Create a notification via the Open MCT API
  2. Notice a ProgressBar artifact next to the notification message contents

Environment

  • Open MCT Version: 3.1.0-next
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image
@ozyx ozyx added type:bug bug:regression It used to work. Now it doesn't :( labels Aug 31, 2023
@ozyx ozyx self-assigned this Aug 31, 2023
@ozyx ozyx mentioned this issue Aug 31, 2023
Merged
15 tasks
@msf-caesar
Copy link

Try with removing or reverting the change introduced in commit #6953 that caused the regression. This should help eliminate the ProgressBar artifacts in the notifications. Additionally, ensure that thorough testing is done before deploying any changes to prevent similar visual bugs from occurring in the future.

scottbell added a commit that referenced this issue Sep 4, 2023
@ozyx @scottbell
fix(#7022): remove ProgressBar artifacts from Notifications (#7024)
9f7b3b9 
* fix: check for null or undefined

* refactor: `lint:fix`

---------

Co-authored-by: Scott Bell <[email protected]>
@unlikelyzero unlikelyzero added the bug:retest Retest without a specific milestone label Feb 27, 2024
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 27, 2024
@ozyx
Copy link
Contributor Author

ozyx commented Mar 5, 2024

Verified Fixed -- Testathon 3/5/24

@ozyx ozyx added verified Tested or intentionally closed and removed bug:retest Retest without a specific milestone labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
bug:regression It used to work. Now it doesn't :( type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(#7022): remove ProgressBar artifacts from Notifications nasa/openmct
3 participants
@ozyx @unlikelyzero @msf-caesar