Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Conductor has browser-based visual issues #6829

Open
5 of 13 tasks
charlesh88 opened this issue Jul 21, 2023 · 0 comments
Open
5 of 13 tasks

Time Conductor has browser-based visual issues #6829

charlesh88 opened this issue Jul 21, 2023 · 0 comments
Assignees
@charlesh88
Labels
bug:platform specific to OS/Browser/Installation method severity:medium type:bug

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jul 21, 2023 •
edited by rukmini-bose
Loading

Summary

All browsers

  • The Date Picker doesn't place itself properly when invoked near the top of the viewport, as in the ITC in the main view:

image

Safari

  • When invoking the inputs popup the whole screen layout is severely broken.
  • The date picker popup is severely broken.
  • In Fixed mode, the tick labels disappear after zooming or panning.

Look at all elements of the TC and ITC in Safari; also unit test this in mobile emulation.

Firefox

  • The real-time popup gets really stretched out. The fixed time popup looks fine. The problem is that the pr-time-input* inputs need a width attribute on them.

image

  • Validation IS working in Firefox, but doesn't show the user hint bubbles in the same way that Chrome and Safari do. MAY NEED TO FILE AS A SEPARATE ISSUE!

Environment

  • Open MCT Version: 3.0.0
  • Deployment Type: /testathon
  • OS:
  • Browser: Safari

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@charlesh88 charlesh88 self-assigned this Jul 21, 2023
@charlesh88 charlesh88 mentioned this issue Jul 20, 2023
Closed
15 tasks
@unlikelyzero unlikelyzero added pr:platform Runs tests against all supported platforms bug:platform specific to OS/Browser/Installation method and removed pr:platform Runs tests against all supported platforms labels Jul 21, 2023
@charlesh88 charlesh88 changed the title Time Conductor in Safari has visual issues Time Conductor has browser-based visual issues Jul 25, 2023
charlesh88 added a commit that referenced this issue Jul 26, 2023
@charlesh88
Closes #6829
f846e6c 
- CSS fixes for Firefox for popup width and input widths.
- Changed markup and CSS for Safari
  - Cannot apply CSS grid to form.
  - Changed ul/li approach to calendar picker, other CSS mods (align-items: center) to fix height issues.
- Modded _constants value to account for reduced height of new TC design.
- Resolved conflicts while applying stashed changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesh88 charlesh88

Labels
bug:platform specific to OS/Browser/Installation method severity:medium type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charlesh88 @unlikelyzero