Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plots in Time Strip are not aligning properly with Plans #6812

Closed
2 of 7 tasks
charlesh88 opened this issue Jul 19, 2023 · 6 comments · Fixed by #7744
Closed
2 of 7 tasks

Plots in Time Strip are not aligning properly with Plans #6812

charlesh88 opened this issue Jul 19, 2023 · 6 comments · Fixed by #7744
Assignees
@shefalijoshi
Labels
severity:critical type:bug verified Tested or intentionally closed

Comments

@charlesh88
Copy link
Contributor

Summary

In Testathon 7/19/23, when a plot view is in a Time Strip with a Plan, it's not aligning properly with the Plan in time due to the plot's Y axis:

Screen Shot 2023-07-19 at 11 02 58 AM

Expected Behavior

The Time Strip is supposed to include any included plot's Y axes width into its offset calculation:

image

Environment

  • Open MCT Version: 3.0.0 SNAPSHOT
  • Deployment Type: /latest, /testathon
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@charlesh88
Copy link
Contributor Author

@akhenry to look for older duplicate issue.

@charlesh88
Copy link
Contributor Author

One possible approach to a fix here is: instead of putting the plot axis into the left column in the DOM, first calc the space needed for the widest Y axis space for all plots included in the view, then use that value to offset the left edge of all other views (plans, imagery, etc.) so that everything lines up.

@shefalijoshi shefalijoshi added this to the Target:3.0.0 milestone Jul 26, 2023
@unlikelyzero unlikelyzero removed this from the Target:3.0.0 milestone Aug 4, 2023
@akhenry akhenry added this to the Target:3.1.0 milestone Aug 7, 2023
@unlikelyzero unlikelyzero removed this from the Target:3.1.0 milestone Sep 11, 2023
@akhenry akhenry added this to the Target:3.2.0 milestone Oct 10, 2023
@unlikelyzero unlikelyzero removed this from the Target:3.2.0 milestone Oct 27, 2023
@unlikelyzero
Copy link
Contributor

still critical

@charlesh88
Copy link
Contributor Author

Testathon 2024-05-09: still not fixed. Purple and yellow dashed lines show elements that should be aligned.

Screenshot 2024-05-09 at 2 31 37 PM

@shefalijoshi shefalijoshi mentioned this issue Jun 11, 2024
Merged
14 tasks
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jun 20, 2024 •
edited
Loading

Testing Instructions:
Create a Time Strip with different types of plots, stacked plots, overlay plots with multiple axes and a plan.
Make sure that The main view of the plots, plans and time system axis are aligned properly. Try this in Fixed timespan and realtime modes.

For example:

image

ozyx added a commit that referenced this issue Jul 22, 2024
@shefalijoshi @ozyx @unlikelyzero
fix(#6812): Align Plot and Plan X-Axes in Time Strips (#7744)
1fae0a6 
* DRAFT - alignment for axes

* Use alignmentContext to manage tick widths instead of passing around as props

* Remove log statements

* Add ability to remove alignment widths for a given y axis

* Fix computation of left margin and width of plan when in the timestrip

* Remove excess padding when there is no left y axis

* Use alignment composable to adjust left margin and width of time system axis

* Fix now marker visibility

* refactor: use built in `Map()` data structure

* refactor: improve readability and conciseness

* docs: improve jsdocs

* refactor: move jsdoc typedefs to bottom of file

* refactor: axis to use vue reactivity

* fix: return alignment as an object of refs

* alignmentMap needs to be shared state, move it out of the useAlignment composable.

* Fix now marker offset

* Add new visual test for time strips

* update with animation stabilization

* Fix failing test due to changed injected property (path -> objectPath)

* change injected property from path to objectPath

* Fix spelling

* Remove unused arguments to function call

---------

Co-authored-by: Jesse Mazzella <[email protected]>
Co-authored-by: Hill, John (ARC-TI)[KBR Wyle Services, LLC] <[email protected]>
@akhenry akhenry added this to the Build 9 RC11 milestone Oct 2, 2024
@akhenry
Copy link
Contributor

akhenry commented Oct 2, 2024

Looks good to me! Verified fixed.

@akhenry akhenry added the verified Tested or intentionally closed label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shefalijoshi shefalijoshi

Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#6812): Align Plot and Plan X-Axes in Time Strips nasa/openmct
4 participants
@charlesh88 @akhenry @shefalijoshi @unlikelyzero