Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating an object while viewing a VIPER Plan kills Open MCT #6455

Closed
4 of 7 tasks
ozyx opened this issue Mar 16, 2023 · 2 comments · Fixed by #6462
Closed
4 of 7 tasks

Creating an object while viewing a VIPER Plan kills Open MCT #6455

ozyx opened this issue Mar 16, 2023 · 2 comments · Fixed by #6462
Assignees
@ozyx
Labels
severity:blocker type:bug
Milestone
Target:2.2.0

Comments

@ozyx
Copy link
Contributor

ozyx commented Mar 16, 2023

Summary

Having a VIPER Plan open and then opening the Create modal (to create any object) causes Open MCT to run out of memory and crash.

Expected vs Current Behavior

Open MCT should not die

Steps to Reproduce

  1. Have a VIPER Plan selected
  2. Try to create any object
  3. Open MCT dies

Environment

  • Open MCT Version: 2.2.0-SNAPSHOT
  • Deployment Type: Testathon
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx added this to the Target:2.2.0 milestone Mar 16, 2023
@ozyx ozyx self-assigned this Mar 16, 2023
ozyx added a commit that referenced this issue Mar 16, 2023
@ozyx
fix(#6455): fix infinite loop
a98c88b 
- When the Create modal is opened, it defaults the object selected in the tree to the parent of the currently selected object. However, if this object is static, it can sometimes have a weird navigationPath and an edge case where we try to infinitely walk up the path to find the parent.

- This adds a fail-safe to verify that the navigationPath by this point contains `/browse/mine` (thus is within a creatable path). If not, it sets the default selected tree item to the "My Items" folder
@ozyx ozyx mentioned this issue Mar 16, 2023
Merged
15 tasks
akhenry added a commit that referenced this issue Mar 17, 2023
@ozyx @akhenry
fix(#6455): fix Create modal tree infinite loop (#6462)
201c669 
* fix(#6455): fix infinite loop

- When the Create modal is opened, it defaults the object selected in the tree to the parent of the currently selected object. However, if this object is static, it can sometimes have a weird navigationPath and an edge case where we try to infinitely walk up the path to find the parent.

- This adds a fail-safe to verify that the navigationPath by this point contains `/browse/mine` (thus is within a creatable path). If not, it sets the default selected tree item to the "My Items" folder

---------

Co-authored-by: Andrew Henry <[email protected]>
@ozyx
Copy link
Contributor Author

ozyx commented Mar 17, 2023 •
edited
Loading

Testing Instructions

  • On Testathon, navigate to a VIPER plan
  • Click the create modal
  • Create any object
  • Verify that Open MCT does not freeze
  • Verify no console errors

@michaelrogers
Copy link
Contributor

Fix verified on testathon 03/17/2023. I was able to create an object via the create modal while a VIPER plan was focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
severity:blocker type:bug
Projects
None yet
Milestone
Target:2.2.0
Development

Successfully merging a pull request may close this issue.

fix(#6455): fix Create modal tree infinite loop nasa/openmct
3 participants
@akhenry @michaelrogers @ozyx