Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InspectorView priority is ignored #6413

Closed
1 of 7 tasks
ozyx opened this issue Mar 13, 2023 · 2 comments · Fixed by #6414
Closed
1 of 7 tasks

InspectorView priority is ignored #6413

ozyx opened this issue Mar 13, 2023 · 2 comments · Fixed by #6414
Labels
type:bug
Milestone
Target:2.2.0

Comments

@ozyx
Copy link
Contributor

ozyx commented Mar 13, 2023

Summary

InspectorViews show up in the same order regardless of priority.

Expected vs Current Behavior

InspectorViews should be able to be reordered by priority.

Steps to Reproduce

  1. Change the priority on an InspectorView to something else
  2. Load the inspector, notice the order doesn't change

Environment

  • Open MCT Version: 2.2.0-SNAPSHOT
  • Deployment Type: local
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx added the type:bug label Mar 13, 2023
@ozyx ozyx added this to the Target:2.2.0 milestone Mar 13, 2023
@ozyx ozyx mentioned this issue Mar 13, 2023
Merged
15 tasks
shefalijoshi added a commit that referenced this issue Mar 15, 2023
@ozyx @shefalijoshi
fix(#6413): Inspector View tab priority (#6414)
22cc28d 
* fix: inspector view tab priority

- fixes issue where inspector view priorities were not being passed to the view registry

* chore: run lint:fix

- eslint sez no danglin' commas! EVER!

* fix: update more viewProviders

---------

Co-authored-by: Shefali Joshi <[email protected]>
@ozyx
Copy link
Contributor Author

ozyx commented Mar 16, 2023

Testing Notes

Test Locally.

  • Modify an InspectorViewProvider's priority to an overwhelmingly positive or negative integer value and ensure that the new order is reflected in the view

@khalidadil
Copy link
Contributor

Verified in Testathon on 03/16/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
Target:2.2.0
Development

Successfully merging a pull request may close this issue.

fix(#6413): Inspector View tab priority nasa/openmct
4 participants
@khalidadil @shefalijoshi @ozyx @unlikelyzero