Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition is not-re-evaluated when node is expanded in the tree #6391

Closed
2 of 7 tasks
akhenry opened this issue Mar 4, 2023 · 3 comments · Fixed by #6437
Closed
2 of 7 tasks

Composition is not-re-evaluated when node is expanded in the tree #6391

akhenry opened this issue Mar 4, 2023 · 3 comments · Fixed by #6437
Labels
severity:critical type:bug
Milestone
Target:2.2.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Mar 4, 2023 •
edited
Loading

Summary

When a child is added to a parent object in another tab (or by another user) it does not appear in the tree even after collapsing and expanding the parent node. It appears that the composition is cached in the tree and is not re-evaluated every time the parent node is expanded.

Expected vs Current Behavior

The new child should appear after collapsing and expanding the parent node.

Steps to Reproduce

  1. Navigate to the same folder in two different Open MCT tabs, and expand it in both
  2. In the first tab, add a child object to the folder
  3. In the second tab, collapse the parent folder and then expand it again
  4. Observe that the new child does not appear even after expanding and collapsing the parent

Environment

  • Open MCT Version: 2.1.6

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx mentioned this issue Mar 6, 2023
Merged
15 tasks
@ozyx ozyx added this to the Target:2.2.0 milestone Mar 6, 2023
@ozyx ozyx assigned ozyx and unassigned ozyx Mar 6, 2023
ozyx added a commit that referenced this issue Mar 15, 2023
@ozyx
fix(#6391): refresh composition on treeItem open
ca7bad3 
- On treeItem open, gets the latest composition from persistence

- Composition was being refreshed, but only within the same instance (mutables)
@ozyx ozyx mentioned this issue Mar 15, 2023
Merged
15 tasks
@ozyx
Copy link
Contributor

ozyx commented Mar 15, 2023

Testing Instructions

  • Follow reproduction steps and verify that the child object shows up on the second tab
  • Repeat above steps with localStorage and CouchDB plugin

ozyx added a commit that referenced this issue Mar 15, 2023
@ozyx @scottbell
fix(#6391): refresh object composition before expanding a tree item (#…
006fa0b 
…6437)

* fix(#6391): refresh composition on treeItem open

- On treeItem open, gets the latest composition from persistence

- Composition was being refreshed, but only within the same instance (mutables)

* test: regression tests for localStorage and couch

---------

Co-authored-by: Scott Bell <[email protected]>
@jvigliotta
Copy link
Contributor

jvigliotta commented Mar 16, 2023 •
edited
Loading

Verified Fixed - Testathon 3/16 on couch, AND local storage

@davetsay
Copy link
Contributor

davetsay commented Mar 16, 2023 •
edited
Loading

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug
Projects
None yet
Milestone
Target:2.2.0
Development

Successfully merging a pull request may close this issue.

fix(#6391): refresh object composition before expanding a tree item nasa/openmct
5 participants
@davetsay @akhenry @ozyx @scottbell @jvigliotta