-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook Annotations UI usage of hover is problematic #6348
Labels
Milestone
Comments
Testing Instructions
|
|
Fix verified during testathon 03/14/2023. |
Verified Fixed - Testathon Pi Day - 23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Current approach of only showing delete buttons on hover over tags applied to a Notebook entry can result in a game of whack-a-mole as the Add Tag button gets moved due to wrapping from increased widths being applied to currently applied tags.
Expected vs Current Behavior
The layout of tag elements and the Add Tag button shouldn't be changed on hover.
Steps to Reproduce
Solution Notes
Slide the Remove "X" button over the existing text without changing the overall width, and dim that text down.

Also, do apply a dropshadow of the tag color to the remove button, something like
style="box-shadow: #0000ff 0 0 2px 1px";
for a tag that's blue. That will prevent the label text from showing through the "X" part of the circle X icon. This would probably be best as a new computed property per tag. Ping @charlesh88 for help with this.Environment
Impact Check List
Additional Information
The text was updated successfully, but these errors were encountered: