-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent tabbing into entry inputs in Notebook #6312
Labels
Milestone
Comments
Testing Notes
|
15 tasks
jvigliotta
added a commit
that referenced
this issue
Feb 9, 2023
Closes #6312 - Set entry inputs to `tabindex="-1"` to prevent tabbing into entry inputs. Co-authored-by: Jamie V <[email protected]>
verified |
Verified testathon 3/9/2023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
In the Notebook, for entries without any embeds, tabbing out of a new entry automatically puts the cursor into the next entry in the list, with the field in "edit" mode. This is HIGHLY undesirable; the user could very easily add extra characters or delete an entry thinking they were doing something else. Nobody wants to tab between Notebook entries sequentially to edit them - in fact, they want the complete opposite.
If an entry has embeds, tabbing moves the focus between embed elements. Unclear what the utility of this is: those elements do not have a Enter key gesture that uses them.
@unlikelyzero Any accessibility or automated test considerations with this change?
Expected vs Current Behavior
The gesture to edit a Notebook entry must be very deliberate, the user should have to deliberately click on the text area of an entry to make it editable.
Solution Notes
Notebook entries are currently being set to use
tabindex="0"
- this should be changed to "-1" to actively prevent tabbing in to the input. A nice-to-have future feature would be to allow tabbing the selected entry, with a full selection occurring and that entry driving the Inspector information.Steps to Reproduce
Environment
Impact Check List
Additional Information
The text was updated successfully, but these errors were encountered: