Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tabbing into entry inputs in Notebook #6312

Closed
1 of 7 tasks
charlesh88 opened this issue Feb 9, 2023 · 3 comments · Fixed by #6315
Closed
1 of 7 tasks

Prevent tabbing into entry inputs in Notebook #6312

charlesh88 opened this issue Feb 9, 2023 · 3 comments · Fixed by #6315

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Feb 9, 2023

Summary

In the Notebook, for entries without any embeds, tabbing out of a new entry automatically puts the cursor into the next entry in the list, with the field in "edit" mode. This is HIGHLY undesirable; the user could very easily add extra characters or delete an entry thinking they were doing something else. Nobody wants to tab between Notebook entries sequentially to edit them - in fact, they want the complete opposite.

If an entry has embeds, tabbing moves the focus between embed elements. Unclear what the utility of this is: those elements do not have a Enter key gesture that uses them.

@unlikelyzero Any accessibility or automated test considerations with this change?

Expected vs Current Behavior

The gesture to edit a Notebook entry must be very deliberate, the user should have to deliberately click on the text area of an entry to make it editable.

Solution Notes

Notebook entries are currently being set to use tabindex="0" - this should be changed to "-1" to actively prevent tabbing in to the input. A nice-to-have future feature would be to allow tabbing the selected entry, with a full selection occurring and that entry driving the Inspector information.

Steps to Reproduce

  1. See Summary above.

Environment

  • Open MCT Version: 2.1.4
  • Deployment Type: MMOC
  • OS:
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

charlesh88 added a commit that referenced this issue Feb 9, 2023
- Set entry inputs to `tabindex="-1"` to prevent tabbing into entry inputs.
@charlesh88
Copy link
Contributor Author

Testing Notes

  1. Populate a Notebook page with a number of entries.
  2. Sort the view by Newest First.
  3. Create a new entry and type some characters into it.
  4. Press the Tab key. Verify that the next entry's input field does not come into focus in its active "edit" style.
  5. Click into an existing entry that is followed in the list by at least one more entry. Perform step 4 again.

jvigliotta added a commit that referenced this issue Feb 9, 2023
Closes #6312
- Set entry inputs to `tabindex="-1"` to prevent tabbing into entry inputs.

Co-authored-by: Jamie V <[email protected]>
@akhenry akhenry added this to the Target:2.2.0 milestone Feb 13, 2023
@davetsay
Copy link
Contributor

davetsay commented Mar 9, 2023

verified

@rukmini-bose
Copy link
Contributor

Verified testathon 3/9/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants