Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition Widget text alignment is broken #5799

Closed
1 of 7 tasks
charlesh88 opened this issue Sep 21, 2022 · 3 comments · Fixed by #5886
Closed
1 of 7 tasks

Condition Widget text alignment is broken #5799

charlesh88 opened this issue Sep 21, 2022 · 3 comments · Fixed by #5886
Labels
bug:visual Visual problem. Not a functional issue help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:trivial type:bug
Milestone
Target:2.1.2

Comments

@charlesh88
Copy link
Contributor

Summary

When a Condition Widget added to a layout

Screen Shot 2022-09-21 at 4 05 17 PM

is not of sufficient width to display it's label, the text is not wrapping as intended:

Screen Shot 2022-09-21 at 4 05 26 PM

Expected vs Current Behavior

Text should center align when wrapping with sufficient padding:

Screen Shot 2022-09-21 at 4 06 49 PM

Steps to Reproduce

  1. Make a Condition Widget with a label that can wrap.
  2. Add the widget to a layout and resize such that the width will force the text to wrap.
  3. Observe that the widget looks like the second example above.

Environment

  • Open MCT Version: 2.0.7
  • Deployment Type: stable
  • OS: Any
  • Browser: Any

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@charlesh88 charlesh88 self-assigned this Sep 21, 2022
@unlikelyzero unlikelyzero added bug:visual Visual problem. Not a functional issue severity:trivial labels Sep 23, 2022
@ozyx ozyx added the help_wanted Help the Open MCT project! label Oct 6, 2022
tobiasbrown added a commit to tobiasbrown/openmct that referenced this issue Oct 18, 2022
@tobiasbrown
[ConditionWidget] Center label text
3b1d938 
Addresses nasa#5799
tobiasbrown added a commit to tobiasbrown/openmct that referenced this issue Oct 18, 2022
@tobiasbrown
[ConditionWidget] Wrap label text
c2fc004 
Addresses nasa#5799
tobiasbrown added a commit to tobiasbrown/openmct that referenced this issue Oct 18, 2022
@tobiasbrown
[ConditionWidget] Add padding to label
4cbd763 
Addresses nasa#5799
@tobiasbrown tobiasbrown mentioned this issue Oct 18, 2022
Merged
15 tasks
tobiasbrown added a commit to tobiasbrown/openmct that referenced this issue Oct 19, 2022
@tobiasbrown
[ConditionWidget] Use interiorMargin value for padding
e7a835b 
Addresses nasa#5799
ozyx pushed a commit that referenced this issue Oct 21, 2022
@tobiasbrown
Centre and wrap Condition Widget label (#5886)
4357d35 
* [ConditionWidget] Center label text

Addresses #5799

* [ConditionWidget] Wrap label text

Addresses #5799

* [ConditionWidget] Add padding to label

Addresses #5799

* [ConditionWidget] Use interiorMargin value for padding

Addresses #5799
@ozyx ozyx added this to the Target:2.1.2 milestone Oct 22, 2022
@ozyx
Copy link
Contributor

ozyx commented Oct 24, 2022 •
edited
Loading

Verified Fixed -- Testathon 10/24/22

@rukmini-bose
Copy link
Contributor

Verified Testathon 10/24

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 10/24/2022

@unlikelyzero unlikelyzero added needs:e2e Needs an e2e test and removed unverified labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:visual Visual problem. Not a functional issue help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:trivial type:bug
Projects
None yet
Milestone
Target:2.1.2
Development

Successfully merging a pull request may close this issue.

Centre and wrap Condition Widget label tobiasbrown/openmct
5 participants
@charlesh88 @ozyx @jvigliotta @unlikelyzero @rukmini-bose