Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry metadata missing timesystem key should warn instead of error #4999

Closed
davetsay opened this issue Mar 25, 2022 · 1 comment · Fixed by #4996
Closed

Telemetry metadata missing timesystem key should warn instead of error #4999

davetsay opened this issue Mar 25, 2022 · 1 comment · Fixed by #4996
Assignees
Milestone

Comments

@davetsay
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If a deployment has multiple time systems and some telemetry does not have all the matching domains, an error is thrown and the UI is stuck in a bad state.

Describe the solution you'd like
A warning that telemetry metadata does not match the time system

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
NASA AMMOS stack has ert, scet, sclk, and lmst time systems for telemetry but messages are only time stamped by GDS based on wall clock. Viewing a message stream and toggling to scet will crash the browser where it would be more useful to alert the user no data will flow, and to switch timesystems.

** Steps to reproduce / Testing Instructions **
requires multiple timesystems installed to test

  1. Select a telemetry endpoint
  2. Toggle through the time systems in the time conductor
  3. If the telemetry does not have a matching domain for the time system, an alert notification should be presented to the user (and to developers in the browser console)
@akhenry
Copy link
Contributor

akhenry commented May 9, 2022

@ozyx to address test coverage

ozyx added a commit that referenced this issue May 12, 2022
- Test for warn if metadata does not match active TimeSystem

- Test for no warn if metadata matches active TimeSystem
jvigliotta pushed a commit that referenced this issue May 16, 2022
…#4996)

* warn user if telemetry not all telemetry metadata matches time system
* create spec file for telemetry collections
* Add tests (#4999)
- Test for warn if metadata does not match active TimeSystem
- Test for no warn if metadata matches active TimeSystem
* unset timeKey if no matching domain found
* Extract errors to constants file and update tests

Co-authored-by: Jesse Mazzella <[email protected]>
@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants