Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Notebook entry layout #4954

Closed
charlesh88 opened this issue Mar 17, 2022 · 3 comments · Fixed by #5036
Closed

Fix Notebook entry layout #4954

charlesh88 opened this issue Mar 17, 2022 · 3 comments · Fixed by #5036
Labels
needs:e2e Needs an e2e test type:enhancement

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Mar 17, 2022 •
edited
Loading

With the addition of user attribution, Notebook entry layouts are more in need of fixing than ever.
@charlesh88 charlesh88 self-assigned this Mar 17, 2022
charlesh88 added a commit that referenced this issue Apr 6, 2022
@charlesh88
Notebook entry tweaks for #4954
5d589ab 
- Standardized entry layout;
- Colors, styles and padding refinements for entry elements;
@charlesh88
Copy link
Contributor Author

Change Refs

image

image

Testing Notes

Ideally test with user attribution enabled.

  1. In the Notebook view, verify that the created datetime and creator are always displayed above the entry as shown in the Change Refs screenshots as above, and that the entry does not align to the right of the created datetime and creator, even when the view area is very wide.
  2. Verify that hovering over an entry and editing looks and feels as expected.

charlesh88 added a commit that referenced this issue Apr 6, 2022
@charlesh88
Notebook entry tweaks for #4954
1b85e0e 
- Fixed linting errors;
@charlesh88 charlesh88 mentioned this issue Apr 6, 2022
Merged
15 tasks
akhenry added a commit that referenced this issue May 18, 2022
@charlesh88 @akhenry
Notebook entry tweaks for #4954 (#5036)
1cdbb34 
* Notebook entry tweaks for #4954
- Standardized entry layout;
- Colors, styles and padding refinements for entry elements;

Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>
@rukmini-bose
Copy link
Contributor

Verified Testathon 06/09/2022

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jun 13, 2022
@unlikelyzero
Copy link
Contributor

Needs Visual Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:e2e Needs an e2e test type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notebook entry tweaks for #4954 nasa/openmct
4 participants
@charlesh88 @akhenry @unlikelyzero @rukmini-bose