Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New forms code needs tests #4539

Closed
4 tasks
akhenry opened this issue Dec 7, 2021 · 0 comments · Fixed by #4758
Closed
4 tasks

New forms code needs tests #4539

akhenry opened this issue Dec 7, 2021 · 0 comments · Fixed by #4758
Assignees
@nikhilmandlik @unlikelyzero
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.5

Comments

@akhenry
Copy link
Contributor

akhenry commented Dec 7, 2021 •
edited by nikhilmandlik
Loading

The recent refactoring of Open MCT forms needs better test coverage.

Summary

The following new components need tests:

  • The new Forms API
  • The new Forms Vue components
  • The new Create Action
  • The new EditPropertiesAction

I would hope to see test coverage increase by at least 0.48% which is what the corresponding PR reduced it by:

Screen Shot 2021-12-07 at 12 16 59 PM

Testing instructions:

verify Testing coverage increased
@akhenry akhenry added severity:blocker type:maintenance tests, chores, or project maintenance labels Dec 7, 2021
@akhenry akhenry mentioned this issue Dec 7, 2021
Closed
@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 5, 2022
nikhilmandlik added a commit that referenced this issue Jan 21, 2022
@nikhilmandlik
New forms code needs tests #4539
6e14eac
@nikhilmandlik nikhilmandlik mentioned this issue Jan 21, 2022
Merged
19 tasks
nikhilmandlik added a commit that referenced this issue Jan 22, 2022
@nikhilmandlik
New forms code needs tests #4539
2829790
nikhilmandlik added a commit that referenced this issue Jan 25, 2022
@nikhilmandlik
New forms code needs tests #4539
12c7f84
nikhilmandlik added a commit that referenced this issue Jan 26, 2022
@nikhilmandlik
New forms code needs tests #4539
687ec73
@unlikelyzero unlikelyzero self-assigned this Mar 15, 2022
akhenry added a commit that referenced this issue May 18, 2022
@nikhilmandlik @jvigliotta
@akhenry @johnhill2 @shefalijoshi
New forms code needs tests #4539 (#4758)
9529933 
* New forms code needs tests #4539

Co-authored-by: Jamie V <[email protected]>
Co-authored-by: Andrew Henry <[email protected]>
Co-authored-by: unlikelyzero <[email protected]>
Co-authored-by: Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhilmandlik nikhilmandlik

@unlikelyzero unlikelyzero

Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.5
Development

Successfully merging a pull request may close this issue.

New forms code needs tests #4539 nasa/openmct
3 participants
@nikhilmandlik @akhenry @unlikelyzero