actionCollection update event looping when open View Large in Display layout #64

[nikhilmandlik]

Description:

When click on 'View Large' in Display layout updateActionItems event triggers in loop and only stop if we navigate away from Display layout

Testing instructions: (local only)

1. add console.log('ObjectFrame, updateActionItems'); in openmct/src/ui/components/ObjectFrame.vue, inside function updateActionItems(actionItems) {
2. create/use Display layout
3. add new /use existing object which has 'View Large'
4. click on 'View Large' and observer log updateActionItems in console
5. close large view still log updateActionItems in console keeps printing.
6. navigate away from Display layout
7. now logging stops.

Expected Result:

should not loop update event

Actual Result:

looping update event

Console Errors: N/A

Screenshots:

[nikhilmandlik]

update: looks like function updateActionItems inside preview-header.vue hides this.actionCollection.hide(HIDDEN_ACTIONS); some actions and actionCollection emits event update which again triggers this updateActionItems function again and so on.

[akhenry]

Verified Fixed.