Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imagery brightness and contrast are affecting the wrong DOM element #3467

Closed
charlesh88 opened this issue Oct 20, 2020 · 7 comments
Closed

Imagery brightness and contrast are affecting the wrong DOM element #3467

charlesh88 opened this issue Oct 20, 2020 · 7 comments
Assignees
@charlesh88
Labels
type:bug

Comments

@charlesh88
Copy link
Contributor

Screen Shot 2020-10-20 at 11 13 03 AM

Controls should only affect the image, not controls. Controls can be made non-visible.
Screen Shot 2020-10-20 at 11 13 40 AM
@charlesh88 charlesh88 self-assigned this Oct 20, 2020
charlesh88 added a commit that referenced this issue Oct 26, 2020
@charlesh88
Fix imagery #3467
7e5185a 
- Move location of imagery controls in markup;
- Refine vertical placement;
charlesh88 added a commit that referenced this issue Oct 26, 2020
@charlesh88
Fix imagery #3467
530960f 
- Fix Firefox-related slider problems: bring over slider fixes and
markup from branch `imagery-view-layers`;
@charlesh88
Copy link
Contributor Author

charlesh88 commented Oct 26, 2020 •
edited
Loading

Testing Notes

  1. Navigate to an image telemetry view or Example Imagery object.
  2. Hover over the image area. Change the image and contrast both quite low to almost completely darken the image.
  3. Verify that the prev and next arrows do not change their appearance as the image is changed.

Screen Shot 2020-10-26 at 4 09 31 PM

  1. Do the above in Firefox, and verify that slider knobs are vertically centered with respect to the slider tracks (green arrows in following screenshot):
    Screen Shot 2020-10-26 at 4 09 45 PM

  2. Add the imagery view into a Display Layout and repeat steps 1 - 3.

  3. Verify that other Imagery view controls, layout and functionality works as expected without regressions.

@charlesh88 charlesh88 mentioned this issue Oct 26, 2020
Merged
charlesh88 added a commit that referenced this issue Oct 26, 2020
@charlesh88
Fix imagery #3467
1e38171 
- Fix linting problem;
jvigliotta added a commit that referenced this issue Nov 2, 2020
@charlesh88 @jvigliotta
Fix Imagery brightness and contrast controls (#3473)
e502fb8 
* Fix imagery #3467

- Move location of imagery controls in markup;
- Refine vertical placement;

* Fix imagery #3467

- Fix Firefox-related slider problems: bring over slider fixes and
markup from branch `imagery-view-layers`;

* Fix imagery #3467

- Fix linting problem;

Co-authored-by: Jamie V <[email protected]>
@shefalijoshi
Copy link
Contributor

@jvigliotta @charlesh88 Is this issue fixed?

@jvigliotta
Copy link
Contributor

@jvigliotta @charlesh88 Is this issue fixed?

Great question. I assume so, but apparently @charlesh88 would probably have a more definitive answer. I thihnk I just added the label.

@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 6/4/2021

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@jvigliotta
Copy link
Contributor

Verified fixed Testathon 6/4/2021

@kobe1104
Copy link
Contributor

kobe1104 commented Jun 4, 2021

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesh88 charlesh88

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@charlesh88 @nikhilmandlik @shefalijoshi @jvigliotta @unlikelyzero @kobe1104