-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notebook] Example Imagery doesn't capture images #2942
Labels
Comments
nikhilmandlik
added a commit
that referenced
this issue
Apr 16, 2020
nikhilmandlik
added a commit
that referenced
this issue
Aug 10, 2020
nikhilmandlik
added a commit
that referenced
this issue
Aug 11, 2020
nikhilmandlik
added a commit
that referenced
this issue
Aug 6, 2021
@nikhilmandlik Needs test notes. |
akhenry
added a commit
that referenced
this issue
Aug 10, 2021
Co-authored-by: Andrew Henry <[email protected]>
Re-opening |
Closing to test in sprint 1.7.8 testathon |
Verified fixed Testathon 9-20-21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related issues:
This is CORS content policy restrictions issue.
Ideal Solution: Images response header need to have property
Access-Control-Allow-Origin
with proper value.Any image with this property missing ll be blocked by canvas capture due to underlying security concerns.
More info available:
html2canvas:
CORS vs Images/canvas:
Testing instructions:
ref: snapshot Display Layout -> /stable/#/browse/mine/df4b6619-ea5c-4432-968d-2ca0f3c0debf/d9ebbefc-32ec-4ab6-9d8f-614748a96809?tc.mode=local&tc.startDelta=900000&tc.endDelta=15000&tc.timeSystem=utc&view=layout.view
pass
images shows up in snapshotImages/url for testing:
The text was updated successfully, but these errors were encountered: