Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObjectAPI] support asynchronous root resolution #1251

Closed
larkin opened this issue Oct 13, 2016 · 0 comments
Closed

[ObjectAPI] support asynchronous root resolution #1251

larkin opened this issue Oct 13, 2016 · 0 comments
Assignees
Milestone

Comments

@larkin
Copy link
Contributor

larkin commented Oct 13, 2016

Based on a discussion in chat with @akhenry and @VWoeltjen...

It was previously possible to decorate the model service and dynamically and asynchronously change the root model composition on first load of the application.

We should support this use case in a developer friendly manner that allows multiple plugins to work together to define roots, instead of requiring them to hijack the functionality of other plugins.

In order to do this, will change a few things:

  • Will move the default root "mine" to a standalone bundle and disable it by default.
  • will implement some method of asynchronously loading roots (either RootProvider or addRoot(function-> promise[roots])).
  • some question as to how roots are ordered, may point to RootProvider being a better option as it allows for future expansion.

@VWoeltjen @akhenry feel free to log extra comments here.

@larkin larkin added this to the Rajaniemi milestone Oct 13, 2016
@larkin larkin self-assigned this Oct 13, 2016
larkin pushed a commit that referenced this issue Oct 14, 2016
My Items root is now opt-in, and does not need to be enabled for all
deployments.  My Items is enabled by default in the development edition.

#1251
larkin pushed a commit that referenced this issue Oct 14, 2016
larkin pushed a commit that referenced this issue Oct 14, 2016
Refactor RootObjectProvider to separate file for simplicty.

#1251
larkin pushed a commit that referenced this issue Oct 14, 2016
Add unit tests for RootRegistry and RootObjectProvider.

#1251
larkin pushed a commit that referenced this issue Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant