Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Scrollable area in tables much longer than content #1216

Closed
akhenry opened this issue Sep 30, 2016 · 7 comments
Closed

[Tables] Scrollable area in tables much longer than content #1216

akhenry opened this issue Sep 30, 2016 · 7 comments
Assignees
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Sep 30, 2016

table-scroll-bug

In historical tables (but problem is probably in mct-table directive and thus not specific to historical tables) the scroll bar allows scrolling well beyond the visible rows of the table.

It looks as though the table in question (historical table with Sine Wave Generator content) probably has many more rows than the 50 displayed, but these are not being rendered for some reason. 50 is a suspicious number as it is the size of the maxDisplayRows variable that determines when the scrolling logic kicks in in the setVisibleRows function. This is where I would look first.

@akhenry akhenry added this to the Rajaniemi milestone Sep 30, 2016
@akhenry akhenry self-assigned this Sep 30, 2016
@larkin
Copy link
Contributor

larkin commented Oct 3, 2016

Might also be a change to html/css with the control bars that causes the wrong element to scroll.

@akhenry
Copy link
Contributor Author

akhenry commented Oct 4, 2016

Have confirmed data loss is occurring in real-time and historical tables.

@akhenry
Copy link
Contributor Author

akhenry commented Oct 4, 2016

Ah, it's super easy. It's due to selecting the wrong element against which to process scroll events. It selects the first child div, which has changed since initial implementation. This needs to be a little more robust.

@akhenry
Copy link
Contributor Author

akhenry commented Oct 4, 2016

Might also be a change to html/css with the control bars that causes the wrong element to scroll.

Yup, this is basically it.

@akhenry akhenry closed this as completed Oct 5, 2016
VWoeltjen added a commit that referenced this issue Oct 7, 2016
[Tables] Fixed table scroll by modifying selection of scrollable element. Fixes #1216
@larkin
Copy link
Contributor

larkin commented Oct 21, 2016

Testathon 2016-10-21: Can't validate in historical tables, appears fixed in realtime tables.

@charlesh88
Copy link
Contributor

Testathon 2016-10-21: Verified in RT Table objects and views. Can't validate in historical tables via WARP.

@akhenry
Copy link
Contributor Author

akhenry commented Oct 21, 2016

Fix was in MctTable directive, so applies to historical tables also.

@larkin larkin removed the unverified label Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants