cherry-pick(#5585): Light refactor of visual tests

nasa · Sep 11, 2023 · bcd5aa6 · bcd5aa6
1 parent 0b949d1
commit bcd5aa6
Show file tree

Hide file tree

Showing 31 changed files with 1,426 additions and 540 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -213,11 +213,13 @@ jobs:
     parameters:
       node-version:
         type: string
+      suite:
+        type: string # ci or full
     executor: pw-focal-development
     steps:
       - build_and_install:
           node-version: <<parameters.node-version>>
-      - run: npm run test:e2e:visual
+      - run: npm run test:e2e:visual:<<parameters.suite>>
       - store_test_results:
           path: test-results/results.xml
       - store_artifacts:
@@ -245,6 +247,8 @@ workflows:
       - perf-test:
           node-version: lts/hydrogen
       - visual-test:
+          name: visual-test-ci
+          suite: ci
           node-version: lts/hydrogen
 
   the-nightly: #These jobs do not run on PRs, but against master at night
@@ -264,6 +268,8 @@ workflows:
       - perf-test:
           node-version: lts/hydrogen
       - visual-test:
+          name: visual-test-nightly
+          suite: full
           node-version: lts/hydrogen
       - e2e-couchdb:
           node-version: lts/hydrogen