[Time Conductor] #933 Fixed code style errors

platform/commonUI/formats/src/UTCTimeFormat.js

@@ -56,7 +56,7 @@ define([
      * the threshold required.
      * @private
      */
-    function getScaledFormat (d) {
+    function getScaledFormat(d) {
         var momentified = moment.utc(d);
         /**
          * Uses logic from d3 Time-Scales, v3 of the API. See
@@ -65,20 +65,32 @@ define([
          * Licensed
          */
         return [
-            [".SSS", function(m) { return m.milliseconds(); }],
-            [":ss", function(m) { return m.seconds(); }],
-            ["HH:mm", function(m) { return m.minutes(); }],
-            ["HH", function(m) { return m.hours(); }],
-            ["ddd DD", function(m) {
+            [".SSS", function (m) {
+                return m.milliseconds();
+            }],
+            [":ss", function (m) {
+                return m.seconds();
+            }],
+            ["HH:mm", function (m) {
+                return m.minutes();
+            }],
+            ["HH", function (m) {
+                return m.hours();
+            }],
+            ["ddd DD", function (m) {
                 return m.days() &&
                     m.date() !== 1;
             }],
-            ["MMM DD", function(m) { return m.date() !== 1; }],
-            ["MMMM", function(m) {
+            ["MMM DD", function (m) {
+                return m.date() !== 1;
+            }],
+            ["MMMM", function (m) {
                 return m.month();
             }],
-            ["YYYY", function() { return true; }]
-        ].filter(function (row){
+            ["YYYY", function () {
+                return true;
+            }]
+        ].filter(function (row) {
             return row[1](momentified);
         })[0][0];
     }
@@ -91,7 +103,7 @@ define([
      * @returns {string} the formatted date
      */
     UTCTimeFormat.prototype.format = function (value, scale) {
-        if (scale !== undefined){
+        if (scale !== undefined) {
             var scaledFormat = getScaledFormat(value, scale);
             if (scaledFormat) {
                 return moment.utc(value).format(scaledFormat);

platform/features/conductor-v2/compatibility/src/ConductorTelemetryDecorator.js

@@ -76,7 +76,7 @@ define(
             }
 
             conductor.on('bounds', amendRequests);
-            return function() {
+            return function () {
                 unsubscribeFunc();
                 conductor.off('bounds', amendRequests);
             };

platform/features/conductor-v2/conductor/src/TimeConductor.js

@@ -112,7 +112,7 @@ define(['EventEmitter'], function (EventEmitter) {
     TimeConductor.prototype.bounds = function (newBounds) {
         if (arguments.length > 0) {
             var validationResult = this.validateBounds(newBounds);
-            if (validationResult !== true){
+            if (validationResult !== true) {
                 throw new Error(validationResult);
             }
             //Create a copy to avoid direct mutation of conductor bounds

platform/features/conductor-v2/conductor/src/timeSystems/LocalClock.js

@@ -25,7 +25,7 @@ define(['./TickSource'], function (TickSource) {
      * @implements TickSource
      * @constructor
      */
-    function LocalClock ($timeout, period) {
+    function LocalClock($timeout, period) {
         TickSource.call(this);
 
         this.metadata = {
@@ -56,7 +56,7 @@ define(['./TickSource'], function (TickSource) {
 
     LocalClock.prototype.tick = function () {
         var now = Date.now();
-        this.listeners.forEach(function (listener){
+        this.listeners.forEach(function (listener) {
             listener(now);
         });
         this.timeoutHandle = this.$timeout(this.tick.bind(this), this.period);
@@ -73,7 +73,7 @@ define(['./TickSource'], function (TickSource) {
         var listeners = this.listeners;
         listeners.push(listener);
 
-        if (listeners.length === 1){
+        if (listeners.length === 1) {
             this.start();
         }
 

platform/features/conductor-v2/conductor/src/timeSystems/TickSource.js

@@ -30,7 +30,7 @@ define([], function () {
      * @interface
      * @constructor
      */
-    function TickSource () {
+    function TickSource() {
         this.listeners = [];
     }
 

platform/features/conductor-v2/conductor/src/timeSystems/TimeSystem.js

@@ -25,7 +25,7 @@ define([], function () {
      * @interface
      * @constructor
      */
-    function TimeSystem () {
+    function TimeSystem() {
         /**
          * @typedef TimeSystemMetadata
          * @property {string} key
@@ -35,7 +35,6 @@ define([], function () {
          * @type {TimeSystemMetadata}
          */
         this.metadata = undefined;
-        this._tickSources = [];
     }
 
     /**

platform/features/conductor-v2/conductor/src/ui/MctConductorAxis.js

@@ -87,7 +87,7 @@ define(
                 //Define a custom format function
                 this.xAxis.tickFormat(function (tickValue) {
                     // Normalize date representations to numbers
-                    if (tickValue instanceof Date){
+                    if (tickValue instanceof Date) {
                         tickValue = tickValue.getTime();
                     }
                     return format.format(tickValue, {
@@ -127,7 +127,7 @@ define(
             }
         };
 
-        return function(conductor, formatService) {
+        return function (conductor, formatService) {
             return new MCTConductorAxis(conductor, formatService);
         };
     }

platform/features/conductor-v2/conductor/src/ui/MctConductorAxisSpec.js

@@ -71,7 +71,7 @@ define(['./MctConductorAxis'], function (MctConductorAxis) {
                 "range"
             ];
             d3 = jasmine.createSpyObj("d3", d3Functions);
-            d3Functions.forEach(function(func) {
+            d3Functions.forEach(function (func) {
                 d3[func].andReturn(d3);
             });
 
@@ -89,7 +89,7 @@ define(['./MctConductorAxis'], function (MctConductorAxis) {
             var mockTimeSystem;
             var mockFormat;
 
-            beforeEach(function() {
+            beforeEach(function () {
                 mockTimeSystem = jasmine.createSpyObj("timeSystem", [
                     "formats",
                     "isUTCBased"

platform/features/conductor-v2/conductor/src/ui/NumberFormat.js

@@ -34,7 +34,7 @@ define([], function () {
     }
 
     NumberFormat.prototype.format = function (value) {
-        if (isNaN(value)){
+        if (isNaN(value)) {
             return '';
         } else {
             return '' + value;

platform/features/conductor-v2/conductor/src/ui/NumberFormatSpec.js

@@ -30,13 +30,13 @@ define(['./NumberFormat'], function (NumberFormat) {
         it("The format function takes a string and produces a number", function () {
             var text = format.format(1);
             expect(text).toBe("1");
-            expect(typeof(text)).toBe("string");
+            expect(typeof text).toBe("string");
         });
 
         it("The parse function takes a string and produces a number", function () {
             var number = format.parse("1");
             expect(number).toBe(1);
-            expect(typeof(number)).toBe("number");
+            expect(typeof number).toBe("number");
         });
 
         it("validates that the input is a number", function () {

platform/features/conductor-v2/conductor/src/ui/TimeConductorController.js

@@ -45,15 +45,15 @@ define(
             this.validation = new TimeConductorValidation(this.conductor);
 
             // Construct the provided time system definitions
-            this.timeSystems = timeSystems.map(function (timeSystemConstructor){
+            this.timeSystems = timeSystems.map(function (timeSystemConstructor) {
                 return timeSystemConstructor();
             });
 
             //Set the initial state of the view based on current time conductor
             this.initializeScope();
 
             this.conductor.on('bounds', this.setFormFromBounds);
-            this.conductor.on('follow', function (follow){
+            this.conductor.on('follow', function (follow) {
                 $scope.followMode = follow;
             });
             this.conductor.on('timeSystem', this.changeTimeSystem);
@@ -67,7 +67,7 @@ define(
         /**
          * @private
          */
-        TimeConductorController.prototype.initializeScope = function() {
+        TimeConductorController.prototype.initializeScope = function () {
             //Set time Conductor bounds in the form
             this.$scope.boundsModel = this.conductor.bounds();
 
@@ -126,10 +126,11 @@ define(
         TimeConductorController.prototype.setFormFromMode = function (mode) {
             this.$scope.modeModel.selectedKey = mode;
             //Synchronize scope with time system on mode
-            this.$scope.timeSystemModel.options = this.conductorViewService.availableTimeSystems()
+            this.$scope.timeSystemModel.options =
+                this.conductorViewService.availableTimeSystems()
                 .map(function (t) {
                     return t.metadata;
-            });
+                });
         };
 
         /**
@@ -204,13 +205,13 @@ define(
          * @param key
          * @see TimeConductorController#setTimeSystem
          */
-        TimeConductorController.prototype.selectTimeSystemByKey = function(key){
-            var selected = this.timeSystems.filter(function (timeSystem){
+        TimeConductorController.prototype.selectTimeSystemByKey = function (key) {
+            var selected = this.timeSystems.filter(function (timeSystem) {
                 return timeSystem.metadata.key === key;
             })[0];
             this.conductor.timeSystem(selected, selected.defaults().bounds);
         };
-        
+
         /**
          * Handles time system change from time conductor
          *
@@ -222,7 +223,7 @@ define(
          */
         TimeConductorController.prototype.changeTimeSystem = function (newTimeSystem) {
             if (newTimeSystem && (newTimeSystem !== this.$scope.timeSystemModel.selected)) {
-                if (newTimeSystem.defaults()){
+                if (newTimeSystem.defaults()) {
                     var deltas = newTimeSystem.defaults().deltas || {start: 0, end: 0};
                     var bounds = newTimeSystem.defaults().bounds || {start: 0, end: 0};
 

platform/features/conductor-v2/conductor/src/ui/TimeConductorControllerSpec.js

@@ -58,13 +58,13 @@ define(['./TimeConductorController'], function (TimeConductorController) {
         });
 
         function getListener(name) {
-            return mockTimeConductor.on.calls.filter(function (call){
+            return mockTimeConductor.on.calls.filter(function (call) {
                 return call.args[0] === name;
             })[0].args[1];
         }
 
-        describe("", function (){
-            beforeEach(function() {
+        describe("", function () {
+            beforeEach(function () {
                 controller = new TimeConductorController(
                     mockScope,
                     mockWindow,
@@ -183,7 +183,7 @@ define(['./TimeConductorController'], function (TimeConductorController) {
             var ts2Metadata;
             var ts3Metadata;
             var mockTimeSystemConstructors;
-            
+
             beforeEach(function () {
                 mode = "realtime";
                 ts1Metadata = {
@@ -304,7 +304,7 @@ define(['./TimeConductorController'], function (TimeConductorController) {
                         metadata: {
                             key: 'testTimeSystem'
                         },
-                        defaults: function() {
+                        defaults: function () {
                             return {
                                 bounds: defaultBounds
                             };
@@ -313,7 +313,7 @@ define(['./TimeConductorController'], function (TimeConductorController) {
 
                 mockTimeSystems = [
                     // Wrap as constructor function
-                    function() {
+                    function () {
                         return timeSystem;
                     }
                 ];