docs: more concise docstrings(#2068) #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narwhals/expr_dt.py
Outdated
Comment on lines
557
to
558
| Examples: | ||
| Examples: |
There was a problem hiding this comment.
no need to have this twice
skritsotalakis
commented
Mar 1, 2025
| ... datetime(2024, 10, 13, 5, 30, 14), | ||
| ... datetime(2065, 1, 1, 10, 20, 30), | ||
| ... ] | ||
| ... } |
There was a problem hiding this comment.
Changing the column name to "a" and inserting 2 datatimes instead of 3 doesn't improve much in long datetime entries. Introducing from datetime import datatime as dtime reduces the output to 3 lines (bellow example) but i m not sure this is desirable.
>>> from datetime import datetime as dtime
>>> df_native = pa.table(
... {"a": [dtime(1978, 1, 1, 1, 1, 1), dtime(2065, 1, 1, 10, 20, 30)]}
... )
There was a problem hiding this comment.
sure thanks, don't worry about it then
if you just check of repetitions like Examples twice or accidental whitespace then we can get this in 👍
* expr_dt * expr_cat * dataframe * dtypes * exp_str - fix slice- * expr_list * expr_name
skritsotalakis
force-pushed
the
docstrings-concise
branch
from
b0d4e6e to
be9ce1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)