Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typing): remove unused ignores #1979

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Conversation

dangotbanned
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

shape: (9, 7)
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
β”‚ file                          ┆ line ┆ column ┆ message                       ┆ hint ┆ code          ┆ severity β”‚
β”‚ ---                           ┆ ---  ┆ ---    ┆ ---                           ┆ ---  ┆ ---           ┆ ---      β”‚
β”‚ str                           ┆ i64  ┆ i64    ┆ str                           ┆ str  ┆ str           ┆ str      β”‚
β•žβ•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•ͺ══════β•ͺ════════β•ͺ═══════════════════════════════β•ͺ══════β•ͺ═══════════════β•ͺ══════════║
β”‚ narwhals/utils.py             ┆ 192  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/utils.py             ┆ 204  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/utils.py             ┆ 209  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/_duckdb/dataframe.py ┆ 254  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/_arrow/dataframe.py  ┆ 112  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/_arrow/dataframe.py  ┆ 134  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/_arrow/dataframe.py  ┆ 305  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/_arrow/dataframe.py  ┆ 679  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β”‚ narwhals/_arrow/series.py     ┆ 358  ┆ -1     ┆ Unused "type: ignore" comment ┆ null ┆ unused-ignore ┆ error    β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜

@dangotbanned
Copy link
Member Author

This isn't a typing issue, it is directly caused by pre-commit not having access to any dependencies (#1966)

@dangotbanned dangotbanned marked this pull request as ready for review February 11, 2025 21:02
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dangotbanned !

@MarcoGorelli MarcoGorelli merged commit fd8ccac into main Feb 11, 2025
28 checks passed
@MarcoGorelli MarcoGorelli deleted the remove-unused-ignores-1 branch February 11, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants