fix(typing): Use correct TypeVar/Union pairs in from_native
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves 4x `pyright` warnings
|
@MarcoGorelli I have a similar fix for edit: oop ship sailed |
dangotbanned
added a commit
to dangotbanned/narwhals
that referenced
this pull request
Feb 4, 2025
10 tasks
MarcoGorelli
pushed a commit
that referenced
this pull request
Feb 4, 2025
Mentioned in #1935 (comment)
dangotbanned
added a commit
to dangotbanned/narwhals
that referenced
this pull request
Feb 6, 2025
Aligns with narwhals-dev#1935, without using `IntoSeriesT` as `v1.Series` is not generic https://narwhals-dev.github.io/narwhals/backcompat/#breaking-changes-carried-out-so-far
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
nw.from_native(obj, eager_only=True, series_only=True)#1928Checklist
If you have comments or can explain your changes, please do so below
Resolves 4x
pyrightwarnings.I was planning to look at fixing (#1928) but these needed to be addressed first