chore: add issue_deprecation_warning to generate_unique_token function #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Nov 12, 2024
| ) | ||
| issue_deprecation_warning(msg, _version="1.13.0") |
There was a problem hiding this comment.
technically this might have beeen slightly earlier, but this is close enough, and the difference woudln't affect when we'd enforce it
|
Thanks @MarcoGorelli for the good first issue and suggestions. This is my first pull request in open-source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
issue_deprecation_warningingenerate_unique_token#1357Comments:
narwhals/narwhals/utils.py. The current implementation uses the genericwarnfunction, which does not correctly set the stacklevel for tracebacks. This has been rectified by usingissue_deprecation_warningfromnarwhals.utilsto ensure consistency and clarity for developers.Key Changes:
warnwithissue_deprecation_warningto improve the clarity and accuracy of deprecation warnings.Checklist
Please let me know if there are any further changes or tests needed.