Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Render table of contents members ordered & removed css reference #1275

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

DeaMariaLeon
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

I think it's easier to find info on ToC if it's ordered.. but feel free to ignore me :-)
The extra_css is not needed and causes a 404.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 28, 2024
@DeaMariaLeon
Copy link
Member Author

It's just for the Table of contents on the right:

Screenshot 2024-10-28 at 19 09 08

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @DeaMariaLeon !

@MarcoGorelli MarcoGorelli merged commit 52949dc into narwhals-dev:main Oct 28, 2024
22 of 23 checks passed
@DeaMariaLeon DeaMariaLeon deleted the mkdocs branch October 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants