cmd/shfmt: change -ln default to "auto" #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The man page describes the logic in detail. In short, the default is no longer just "assume bash", as it will try to detect the language from the filename and shebang, and only fall back to "bash" if those fail. Users who specify a language themselves, either via -ln or editorconfig, should see no change in behavior whatsoever. Those relying on the default should generally see an improvement, as they might no longer have issues with directories mixing languages. One potential regression is cases like: $ cat foo.sh foo=(bar baz) # actually bash That is, bash scripts which use "sh" extensions or shebangs. "sh" stands for POSIX shell, so the new logic will parse them as such, whereas the old logic would parse them as bash. Still, that seems like an easy fix on the part of the user: they can either change the extension or shebang to be clear, or they can explicitly set up the option to "bash". Note that the added "auto" logic applies to all kinds of inputs: explicit files, directories to be walked, and standard input. Fixes #622.
|
Going to merge this for now. Reviews and testing are still very much welcome, even after this lands in master. |
|
Tested (better late than never I guess); filed #802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #622.