Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Infallible instead of void #1761

Merged
merged 1 commit into from
May 10, 2023
Merged

Use Infallible instead of void #1761

merged 1 commit into from
May 10, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented May 10, 2023 •
edited
Loading

We might be able to use standard Infallible instead of void to describe the type that never happens.

Xuanwo
Xuanwo approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 05bdf4b into mozilla:main May 10, 2023
@tottoto tottoto deleted the use-infallible-instead-of-void branch May 10, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @Xuanwo