Skip sorting when there is only one node #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Mar 30, 2020
|
I have to get my Javascript dev environment setup but I'll work on this at some point today. |
|
I added a test case for when |
mourner
approved these changes
Mar 31, 2020
jbuckmccready
referenced
this pull request
in FObermaier/NetTopologySuite.SandBox
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If numItems <= nodeSize then there is no reason to perform the Hilbert index sort since there is only the root box and one node/tier of boxes below it.
For many use cases this wont provide a meaningful performance gain. However, in the case of repeated and varied input counts for which many may be smaller than nodeSize it is significant (I am seeing around 25-40% increase in speed for some of my use cases in c++), and it comes at almost no cost (a single compare) in the case of larger input counts.