GODRIVER-2871 Unexport optional setter for internal-package logger #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2871
Summary
This PR unexports the WithLogger server configuration setter. This function sets an internal-package object to the server configuration, which is useless to an external user.
Background & Motivation
The configuration of the topology server includes a functional setter that allows for the export of the Logger struct from the internal/logger package. However, since this setter is not intended for use by external users who cannot import data from the internal package, it is recommended to unexport the WithLogger function to prevent confusion.
This setter was added as a part of the work for GODRIVER-2586 , adding log messages to CMAP. WithLogger is not currently exported as part of the experimental API in an existing release.