GetUserId by organization name and user name

[tapaszto]

This is a feature upgrade utilizing the user entitlements DevOps API
The GeUserID function of the UserEntitlementsService returns the Azure DevOps user id by the organization name and user name, this functionality is required to be able to fix an Azure related bug of runatlantis/atlantis
New files:
userentitlements.go: contains the new functionality
examples/getuserid/main.go: an example of using the new functionality
Modified files:
azuredevops.go: UserEntitlementService is added

[Dilergore]

Hey @mcdafydd,

We are planning to fix the merge issue bug in Atlantis which for we need this as a prereq. Could you please review this so we can continue the work on the Atlantis side?

runatlantis/atlantis#1152

[mcdafydd]

Thanks for this. I will get to it later today.

…

On Fri, Nov 27, 2020, 4:28 AM Tibor Zold ***@***.***> wrote: Hey @mcdafydd <https://github.com/mcdafydd>, We are planning to fix the merge issue bug in Atlantis which for we need this as a prereq. Could you please review this so we can continue the work on the Atlantis side? runatlantis/atlantis#1152 <runatlantis/atlantis#1152> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVWDNVXWONTPGT4SMZOSZDSR5WKXANCNFSM4UCUDLAQ> .

[mcdafydd]

Hello,

I think we can remove the NewRequestEx() approach. We do something similar with a custom baseURL here:

go-azuredevops/azuredevops/users.go

Lines 148 to 150 in aa2ceb1

	URL := fmt.Sprintf("%s%s/_apis/graph/users?api-version=5.1-preview.1",
	s.client.VsspsBaseURL.String(),
	owner,

Also, would you add a simple test for each func and add omitempty to any receiving (response) JSON struct members?

Appreciate the submission!

[tapaszto]

Hi,

I will make it on Monday, thanks.

[tapaszto]

Hi @mcdafydd,

I made the requested changes, can You please review it, and approve the PR?

[tapaszto]

Hi @mcdafydd,

Thanks for merging the PR, can You roll out a new release?

[mcdafydd]

Oh yes - sorry about that.

[mcdafydd]

Pushed tag v0.12.0