Make policy checks its own apply requirement. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarvar
reviewed
Apr 5, 2021
| for _, globalReq := range globalApplyReqs { | ||
| for _, currReq := range r.ApplyRequirements { | ||
| if globalReq == currReq { | ||
| continue OUTER |
There was a problem hiding this comment.
I'm trying to understand this part, doesn't this create infinite loop? This is basically a GOTO statement right?
There was a problem hiding this comment.
hmm, no this just allows us to continue from the next iteration of the outer loop without all the ugly syntax of having a boolean to flag this and then checking that in the outer loop before appending the requirement to the result list.
msarvar
reviewed
Apr 5, 2021
| @@ -85,6 +85,19 @@ func (g GlobalCfg) Validate() error { | |||
|
|
|||
| func (g GlobalCfg) ToValid(defaultCfg valid.GlobalCfg) valid.GlobalCfg { | |||
| workflows := make(map[string]valid.Workflow) | |||
|
|
|||
| applyReqs := defaultCfg.Repos[0].ApplyRequirements | |||
There was a problem hiding this comment.
Let's maybe put a comment here noting that we always initialize global config with at least 1 repo.
msarvar
approved these changes
Apr 6, 2021
nishkrishnan
added a commit
that referenced
this pull request
Apr 12, 2021
msarvar
pushed a commit
that referenced
this pull request
Apr 19, 2021
* Make policy checks its own apply requirement. (#61) * Remove warning from docs.
nishkrishnan
added a commit
that referenced
this pull request
Jun 28, 2021
msarvar
pushed a commit
that referenced
this pull request
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this as it's own apply requirement ensures that a project can be applied if it has it's policies passing, independent of whether other projects fail the policy check or not.
Additionally, the error messaging is clearer here.