Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two changes:
SimpleLogger
with it's interfaceSimpleLogging
which makes it easier to swap out loggers going forwardSimpleLogger
in favor ofStructuredLogger
which allows us to better analyze logs in our log management system we choose.Right now the real changes are scopped to
simple_logger.go
andlogging_test
the rest of the changes are just interface changes + test changes to support the new constructor forNoopLogger
Note: As a base logger I'm using zap