Support pre-workflow hooks on all comment/auto triggered commands. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarvar
previously approved these changes
Feb 4, 2021
| autoPlanRunner := buildCommentCommandRunner(c, models.PlanCommand) | ||
| if autoPlanRunner == nil { | ||
| ctx.Log.Err("invalid autoplan command") | ||
| return |
There was a problem hiding this comment.
Don't you want this? Otherwise go will panic.
There was a problem hiding this comment.
oh i think this can be removed since we panic if we can't get it from the map in the function itself:
| WorkingDirLocker: workingDirLocker, | ||
| WorkingDir: workingDir, | ||
| Drainer: drainer, | ||
| PreWorkflowHookRunner: &runtime.PreWorkflowHookRunner{}, | ||
| PreWorkflowHookRunner: runtime.DefaultPreWorkflowHookRunner{}, |
There was a problem hiding this comment.
My assumption was that you only need pointers if you have a need to reference the underlying data without copying it but this struct is stateless.
msarvar
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our usecase, having this on PR open/update is not good enough since
atlantis unlockfor example cleans up the directory and each comment command attempts to clone the directory. Since we are dynamically generating the atlantis.yaml this breaks integrations until a PR event occurs again.TODO: