Add preliminary check before registering new receivers in the log handler #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarvar
reviewed
Feb 3, 2022
Comment on lines
121
to
123
| defer func() { | ||
| p.receiverBuffersLock.RUnlock() | ||
| }() |
There was a problem hiding this comment.
don't think you need to wrap it into anonymous function here.
msarvar
approved these changes
Feb 4, 2022
Aayyush
added a commit
that referenced
this pull request
Feb 14, 2022
* Add UUID for Log Streaming Job ID (#167) * Update log handler to close buffered channels when an operation is complete (#170) * Add preliminary check before registering new receivers in the log handler (#173) * Using projectOutputBuffers to check for jobID instead of receiverBuffers (#181) * Refactor log handler (#175) * Reverting go.mod and go.sum * Fix lint errors * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't have a check in place before we register new web socket connections. As a result, if someone were to visit the jobs URL with invalid job ID, we would still register the connection and create go channels which could cause memory issues in the future.
So, we add a check to ensure a valid job exists in our log handler before we register new receivers.