fix: move QUEUE to globalThis scope;
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uvu/run ALWAYS loaded after core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
QUEUEto theglobalThisscope.This guarantees that "both halves" of
uvuare using the same internal value, as described in #69With the linked reproduction, applying this PR required no other changes in order for the reproduction to work. Additionally, these combinations all worked out of the box:
uvu -r esm testson Node 14 (default)"type": "module"on Node 14uvu testson Node 14 +"type": "module"node -r esm tests/test.json Node 14"type": "module"on Node 14node tests/test.json Node 14 +"type": "module"The approach still works within browsers.
Closes #69