Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter isNode check #63

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Stricter isNode check #63

merged 2 commits into from
Nov 9, 2020

Conversation

zigomir
Copy link
Contributor

@zigomir zigomir commented Nov 5, 2020

Hi!

I tried running uvu with vite and because vite injects env on to window.process, uvu would fail for me at process.argv.some().

uvu   vite

Other front end tools also sometimes override process so that client code can grab ENV variables.

Thanks for creating uvu, it's great!

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #63 (5780b72) into master (0f9dfb7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files           3        3           
  Lines         297      297           
=======================================
  Hits          267      267           
  Misses         30       30           
Impacted Files Coverage Δ
src/index.js 76.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9dfb7...5780b72. Read the comment docs.

@lukeed
Copy link
Owner

lukeed commented Nov 9, 2020

Hey, thank you :)

I updated it a bit so that it's more inline with the underlying kleur check for Node: lukeed/kleur#42

Nearly everything that polyfills process doesnt polyfill process.stdout – so this should close #53 too

@lukeed lukeed merged commit d736cef into lukeed:master Nov 9, 2020
@zigomir zigomir deleted the stricter-node-check branch November 9, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants