Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: fix 0 search results with specific search engine #6487

Merged
merged 7 commits into from
Feb 25, 2025
Merged

๐Ÿ› fix: fix 0 search results with specific search engine #6487

merged 7 commits into from
Feb 25, 2025

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Feb 25, 2025 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  • ๅฆ‚ๆžœๆŒ‡ๅฎšไบ† SearXNG ็š„็‰นๅฎšๆœ็ดขๅผ•ๆ“Ž๏ผŒๆฒกๆœ‰่ฟ”ๅ›ž็ป“ๆžœ็š„่ฏ๏ผŒๅฐ่ฏ•ๅŽปๆŽ‰ๅผ•ๆ“Ž้™ๅˆถ็„ถๅŽ้‡ๆ–ฐๆœ็ดขไธ€ๆฌก
  • ไผ˜ๅŒ–้ƒจๅˆ†ๆ ทๅผ

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 25, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview Feb 25, 2025 5:59am
lobe-chat-desktop โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 25, 2025 5:59am
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 25, 2025 5:59am

@dosubot dosubot bot added the ๐Ÿ› Bug Something isn't working | ็ผบ้™ท label Feb 25, 2025
@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.01235% with 34 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (b61b5fc) to head (f209f61).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/store/chat/slices/builtinTool/actions/dalle.ts 81.74% 23 Missing โš ๏ธ
...c/store/chat/slices/builtinTool/actions/searXNG.ts 26.66% 11 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6487      +/-   ##
==========================================
- Coverage   91.49%   91.48%   -0.02%     
==========================================
  Files         697      699       +2     
  Lines       65128    65173      +45     
  Branches     4600     3153    -1447     
==========================================
+ Hits        59590    59624      +34     
- Misses       5538     5549      +11
Flag Coverage ฮ”
app 91.48% <79.01%> (-0.02%) โฌ‡๏ธ
server 97.57% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title ๐Ÿ› fix: update ๐Ÿ› fix: search again if 0 results return with specific search engine Feb 25, 2025
@arvinxx arvinxx changed the title ๐Ÿ› fix: search again if 0 results return with specific search engine ๐Ÿ› fix: fix 0 results return with specific search engine Feb 25, 2025
@arvinxx arvinxx changed the title ๐Ÿ› fix: fix 0 results return with specific search engine ๐Ÿ› fix: fix 0 search results with specific search engine Feb 25, 2025
@arvinxx arvinxx merged commit 74a09e2 into main Feb 25, 2025
17 of 18 checks passed
@arvinxx arvinxx deleted the fix/search-with-empty branch February 25, 2025 06:14
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Feb 25, 2025
@semantic-release-bot
๐Ÿ”– chore(release): v1.64.2 [skip ci]
ae84362 
### [Version&nbsp;1.64.2](v1.64.1...v1.64.2)
<sup>Released on **2025-02-25**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix 0 search results with specific search engine.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix 0 search results with specific search engine, closes [#6487](#6487) ([74a09e2](74a09e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.64.2 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Feb 25, 2025
@semantic-release-bot
๐Ÿ”– chore(release): v1.105.0 [skip ci]
17e73e7 
## [Version&nbsp;1.105.0](v1.104.1...v1.105.0)
<sup>Released on **2025-02-25**</sup>

#### โœจ Features

- **misc**: Support application search with searchXNG.

#### ๐Ÿ› Bug Fixes

- **misc**: Disable fc for ds-v3 series, fix 0 search results with specific search engine.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Support application search with searchXNG, closes [lobehub#6452](https://github.com/bentwnghk/lobe-chat/issues/6452) ([b61b5fc](b61b5fc))

#### What's fixed

* **misc**: Disable fc for ds-v3 series, closes [lobehub#6486](https://github.com/bentwnghk/lobe-chat/issues/6486) ([0092213](0092213))
* **misc**: Fix 0 search results with specific search engine, closes [lobehub#6487](https://github.com/bentwnghk/lobe-chat/issues/6487) ([74a09e2](74a09e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
likaiqiang pushed a commit to likaiqiang/lobe-chat that referenced this pull request Feb 26, 2025
@arvinxx @likaiqiang
๐Ÿ› fix: fix 0 search results with specific search engine (lobehub#6487)
78ac2cd 
* update

* improve plugin loading state

* improve loading style

* update favicon

* improve search display

* add search results

* fix lint
likaiqiang pushed a commit to likaiqiang/lobe-chat that referenced this pull request Feb 26, 2025
@semantic-release-bot @likaiqiang
๐Ÿ”– chore(release): v1.64.2 [skip ci]
4da27b5 
### [Version&nbsp;1.64.2](lobehub/lobe-chat@v1.64.1...v1.64.2)
<sup>Released on **2025-02-25**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix 0 search results with specific search engine.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix 0 search results with specific search engine, closes [lobehub#6487](lobehub#6487) ([74a09e2](lobehub@74a09e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
๐Ÿ› Bug Something isn't working | ็ผบ้™ท released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot