Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: add LLM_VISION_IMAGE_USE_BASE64 to support local s3 in vision model #3887

Merged
merged 8 commits into from
Sep 11, 2024
Merged

๐Ÿ› fix: add LLM_VISION_IMAGE_USE_BASE64 to support local s3 in vision model #3887

merged 8 commits into from
Sep 11, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Sep 10, 2024 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

add an env LLM_VISION_IMAGE_USE_BASE64=1 will make the OpenAI and other models send image with base64

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

refs

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 11, 2024 2:48am
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 11, 2024 2:48am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added vision ๐Ÿ› Bug Something isn't working | ็ผบ้™ท labels Sep 10, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (9d7e47c) to head (96cea15).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/imageToBase64.ts 93.75% 1 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3887      +/-   ##
==========================================
+ Coverage   91.85%   91.88%   +0.02%     
==========================================
  Files         459      460       +1     
  Lines       30755    30781      +26     
  Branches     2121     3114     +993     
==========================================
+ Hits        28250    28282      +32     
+ Misses       2505     2499       -6
Flag Coverage ฮ”
app 91.88% <98.64%> (+0.02%) โฌ†๏ธ
server 97.36% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@arvinxx arvinxx changed the title ๐Ÿ› fix: add LLM_VISION_IMAGE_TYPE to support local s3 in vision model ๐Ÿ› fix: add LLM_VISION_IMAGE_USE_BASE64 to support local s3 in vision model Sep 11, 2024
@arvinxx arvinxx merged commit 16e57ed into main Sep 11, 2024
11 checks passed
@arvinxx arvinxx deleted the fix/local-s3-vision-usage branch September 11, 2024 07:05
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.16.3 [skip ci]
e9b87fc 
### [Version&nbsp;1.16.3](v1.16.2...v1.16.3)
<sup>Released on **2024-09-11**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Add `LLM_VISION_IMAGE_USE_BASE64` to support local s3 in vision model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Add `LLM_VISION_IMAGE_USE_BASE64` to support local s3 in vision model, closes [#3887](#3887) ([16e57ed](16e57ed))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.16.3 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 11, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.59.0 [skip ci]
55273e5 
## [Version&nbsp;1.59.0](v1.58.16...v1.59.0)
<sup>Released on **2024-09-11**</sup>

#### โœจ Features

- **misc**: Add Fireworks AI Model Provider, Add Spark model provider.

#### ๐Ÿ› Bug Fixes

- **misc**: Add `LLM_VISION_IMAGE_USE_BASE64` to support local s3 in vision model.

#### ๐Ÿ’„ Styles

- **ui**: Improve UI layout and text.
- **misc**: Reorder the provider list, Update CustomLogo, update spark check model to spark-lite & default disable useless model, update Upstage model list.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Add Fireworks AI Model Provider, closes [lobehub#3392](https://github.com/bentwnghk/lobe-chat/issues/3392) [lobehub#48](https://github.com/bentwnghk/lobe-chat/issues/48) ([fa0d84d](fa0d84d))
* **misc**: Add Spark model provider, closes [lobehub#3098](https://github.com/bentwnghk/lobe-chat/issues/3098) [lobehub#25](https://github.com/bentwnghk/lobe-chat/issues/25) ([fc85c20](fc85c20))

#### What's fixed

* **misc**: Add `LLM_VISION_IMAGE_USE_BASE64` to support local s3 in vision model, closes [lobehub#3887](https://github.com/bentwnghk/lobe-chat/issues/3887) ([16e57ed](16e57ed))

#### Styles

* **ui**: Improve UI layout and text, closes [lobehub#3762](https://github.com/bentwnghk/lobe-chat/issues/3762) ([7c08f29](7c08f29))
* **misc**: Reorder the provider list, closes [lobehub#3886](https://github.com/bentwnghk/lobe-chat/issues/3886) ([4d641f5](4d641f5))
* **misc**: Update CustomLogo, closes [lobehub#3874](https://github.com/bentwnghk/lobe-chat/issues/3874) ([dd7c8df](dd7c8df))
* **misc**: Update spark check model to spark-lite & default disable useless model, closes [lobehub#3885](https://github.com/bentwnghk/lobe-chat/issues/3885) ([9d7e47c](9d7e47c))
* **misc**: Update Upstage model list, closes [lobehub#3890](https://github.com/bentwnghk/lobe-chat/issues/3890) ([82e2570](82e2570))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@BiFangKNT BiFangKNT mentioned this pull request Sep 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
๐Ÿ› Bug Something isn't working | ็ผบ้™ท released size:L This PR changes 100-499 lines, ignoring generated files. vision
Projects
None yet
Milestone
No milestone
2 participants
@arvinxx @lobehubbot