Use generativity to ensure soundness even with NLL #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
reviewed
May 24, 2019
Kerollmops
reviewed
May 24, 2019
It was recently found out that edition 2018 NLL doesn't ensure lifetime uniqueness with the current setup. This uses a slightly different scheme, which unfortunately makes `InvariantLifetime` part of the public API, but that's a small price to pay for soundness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was recently found out that edition 2018 NLL doesn't ensure lifetime uniqueness with the current setup. This uses a slightly different scheme, which unfortunately makes
InvariantLifetimepart of the public API, but that's a small price to pay for soundness.This fixes #22