Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agents): Add delete agent command and refactor other agent commands #73

Merged
merged 6 commits into from
May 25, 2022
Merged

feat(agents): Add delete agent command and refactor other agent commands #73

merged 6 commits into from
May 25, 2022

Conversation

PrayagS
Copy link
Contributor

@PrayagS PrayagS commented May 21, 2022 •
edited
Loading

This PR adds the following changes,

  • a command to delete (read delete and disconnect) a ChaosAgent present in the project.
  • adds the field isRegistered in the output of get agents command.
  • refactors the create agent command to connect agent for consistency.

Signed-off-by: PrayagS [email protected]

@Saranya-jena
Copy link
Collaborator

Hi @PrayagS Can you add screenshots of the command running on the terminal?

@ajeshbaby
Copy link

reference -- litmuschaos/litmus#3604

@PrayagS PrayagS force-pushed the feat-delete-agent-command branch 4 times, most recently from e090e79 to 1cacc81 Compare May 23, 2022 07:02
@PrayagS
Copy link
Contributor Author

PrayagS commented May 23, 2022

@Saranya-jena Pushed the final changes. Please find the screenshot below,

image

@PrayagS PrayagS changed the title feat(agents): Add delete agent command feat(agents): Add delete agent command and refactor other agent commands May 24, 2022
@imrajdas
Copy link
Member

@PrayagS Can you resolve the merge conflicts

@PrayagS PrayagS force-pushed the feat-delete-agent-command branch from 55486ca to 0cd52ba Compare May 24, 2022 12:04
@imrajdas imrajdas merged commit 8646502 into litmuschaos:master May 25, 2022
@imrajdas imrajdas mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrajdas imrajdas imrajdas approved these changes

@Saranya-jena Saranya-jena Saranya-jena approved these changes

@Jonsy13 Jonsy13 Jonsy13 approved these changes

@SarthakJain26 SarthakJain26 SarthakJain26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PrayagS @Saranya-jena @ajeshbaby @imrajdas @Jonsy13 @SarthakJain26