pkg/logrusutil: Fix PropagateJSON to use logger; add tests #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
refactor-pkg-logrusutil
branch
2 times, most recently
from
3d203a7 to
a557c8d
Compare
AkihiroSuda
reviewed
Dec 14, 2023
Signed-off-by: Oleksandr Redko <[email protected]>
alexandear
force-pushed
the
refactor-pkg-logrusutil
branch
from
a557c8d to
545b764
Compare
alexandear
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the function
logrusutil.PropagateJSONby removinggoto, changing fallbacklogrus.Info(which prints to stderr) tologger.Info, and adding unit tests.