-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: the AIG framework to track negations in a more efficient way #7381
Draft
hargoniX
wants to merge
4
commits into
master
Choose a base branch
from
hbv/aig_not
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench |
Mathlib CI status (docs):
|
Here are the benchmark results for commit f88c3a2. Benchmark Metric Change
=====================================================================
- bv_decide_inequality.lean branches 19.5% (3819.5 σ)
- bv_decide_inequality.lean instructions 23.1% (3848.1 σ)
- bv_decide_inequality.lean maxrss 21.5% (364.9 σ)
- bv_decide_inequality.lean task-clock 33.2% (170.0 σ)
- bv_decide_inequality.lean wall-clock 33.1% (324.2 σ)
+ bv_decide_mod branches -9.1% (-720.0 σ)
+ bv_decide_mod instructions -10.4% (-821.1 σ)
+ bv_decide_mod maxrss -2.1% (-222.0 σ)
+ bv_decide_mod task-clock -22.4% (-15.7 σ)
+ bv_decide_mod wall-clock -22.3% (-15.4 σ)
+ bv_decide_mul branches -13.8% (-1039.8 σ)
+ bv_decide_mul instructions -15.0% (-1244.2 σ)
+ bv_decide_mul maxrss -6.7% (-1777.0 σ)
- bv_decide_realworld branches 81.7% (3874.9 σ)
- bv_decide_realworld instructions 77.4% (4549.0 σ)
- bv_decide_realworld maxrss 49.5% (3014.4 σ)
- bv_decide_realworld task-clock 50.6% (32.1 σ)
- bv_decide_realworld wall-clock 49.6% (19.4 σ)
+ ilean roundtrip parse -3.5% (-10.4 σ)
+ import Lean task-clock -8.7% (-83.1 σ)
+ import Lean wall-clock -8.7% (-74.9 σ)
- liasolver task-clock 3.5% (61.7 σ)
- liasolver wall-clock 3.4% (56.9 σ)
+ omega_stress.lean async branch-misses -5.6% (-13.4 σ)
- stdlib instantiate metavars 13.6% (14.6 σ)
+ workspaceSymbols task-clock -4.8% (-12.0 σ)
+ workspaceSymbols wall-clock -4.8% (-12.0 σ) |
!bench |
Here are the benchmark results for commit 35dc1d8. Benchmark Metric Change
=============================================================
+ bv_decide_inequality.lean branches -9.4% (-1289.4 σ)
+ bv_decide_inequality.lean instructions -9.1% (-800.1 σ)
- bv_decide_mod branches 10.2% (141.4 σ)
- bv_decide_mod instructions 12.1% (166.5 σ)
- bv_decide_mod task-clock 22.7% (19.1 σ)
- bv_decide_mod wall-clock 22.6% (18.2 σ)
+ bv_decide_mul branches -4.0% (-336.7 σ)
+ bv_decide_mul instructions -4.8% (-374.6 σ)
+ bv_decide_mul maxrss -1.1% (-27.1 σ)
- bv_decide_realworld branches 947.2% (10772.1 σ)
- bv_decide_realworld instructions 930.2% (14191.7 σ)
- bv_decide_realworld maxrss 448.8% (24605.6 σ)
- bv_decide_realworld task-clock 570.7% (172.6 σ)
- bv_decide_realworld wall-clock 562.7% (195.1 σ)
- stdlib dsimp 3.7% (46.0 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-language
Language features, tactics, and metaprograms
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO