Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace bad simp lemmas for Id #7352

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

fix: replace bad simp lemmas for Id #7352

wants to merge 14 commits into from

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Mar 5, 2025 •
edited
Loading

This PR avoids simp dead ends for the Id monad.

The old simp lemmas led to Id.run (pure 37) being simplified to Id.run 37, instead of the desirable 37.

@eric-wieser
fix: replace bad simp lemmas for Id
36b39d1 
This PR avoids `simp` dead ends for the `Id` monad.

These simp lemmas lead to `Id.run (pure 37)` being simplified to `Id.run 37`, instead of the desirable `37`.
@eric-wieser
Copy link
Contributor Author

changelog-library

@github-actions github-actions bot added the changelog-library Library label Mar 5, 2025
@eric-wieser eric-wieser requested a review from digama0 as a code owner March 5, 2025 22:46
@eric-wieser eric-wieser requested a review from kim-em as a code owner March 5, 2025 22:58
@eric-wieser eric-wieser requested review from TwoFX and tydeu as code owners March 6, 2025 01:26
@eric-wieser eric-wieser marked this pull request as draft March 6, 2025 01:48
@eric-wieser
Copy link
Contributor Author

I've split some helper lemmas to #7356, which are independent of this fix

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 6, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9ae2ac39c9512461643e268f0feff5654044776f --onto 5536281238dff2fb4e0a54da472d4f0d6496069e. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-06 03:18:31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@TwoFX TwoFX Awaiting requested review from TwoFX TwoFX is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

@david-christiansen david-christiansen Awaiting requested review from david-christiansen david-christiansen is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-wieser @leanprover-community-bot