Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SistentComponents] Fix Hydtration Errors #6287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[SistentComponents] Fix Hydtration Errors #6287

wants to merge 2 commits into from
+120 −119

Conversation

falgunmpatel
Copy link

Description

  • Implemented Proper nesting of
  • anf elements.
  • Removed default props from SEO Comonent due to deprecation warning from next update.
  • Moved named exports of section-nav, Header to new dedicatied components, as some warning were shown (see image below). Also they can be generalised to be reused in all other components (Generalization will be done in some other PR).

Also removed
Screenshot 2025-03-08 at 2 19 20 PM

This PR fixes #6286

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@falgunmpatel
Create separate components for header and section-nav from the select…
c22a0da 
…/index.js, as they can be genralised and reused in other components as well.

Signed-off-by: Falgun Patel <[email protected]>
@falgunmpatel
- Improved nesting of list elements and anchor elements
80a61e8 
- removed usage of defaultProps due to deprecation warnings for making it future safe.

Signed-off-by: Falgun Patel <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 8, 2025

🚀 Preview for commit 80a61e8 at: https://67cc2bf0f7d773407946f5db--layer5.netlify.app

@GARY121github GARY121github mentioned this pull request Mar 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/handbook project/sistent
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SistentComponents] Hydration issue in the sistent component section
2 participants
@falgunmpatel @l5io