langchain: clean pyproject ruff section #30070
Merged
+17
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures lint dep-group is installed before running ruff
Removed exclude and ignore rules that were no longer relevant
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:S
dskarbrevik
changed the title
dosubot
bot
added
langchain
|
@ccurme hey sorry to pick on you, you had the coolest profile icon. Any chance you could review this PR? |
dskarbrevik
changed the title
ccurme
approved these changes
Mar 9, 2025
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| .EXPORT_ALL_VARIABLES: | |||
| UV_FROZEN = true | |||
| UV_NO_SYNC = true | |||
There was a problem hiding this comment.
I set this at the top as a convenience for running make api_docs_quick_preview locally, but maybe that was a bad idea. make format should now sync automatically. Let me know if this doesn't work for you.
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/Makefile- added extra step tomake formatandmake lintto ensure the lint dep-group is installed before running ruff (documented in issue make format - fails to install lint dep-group resulting in a Failed to spawn error #30069)/pyproject.toml- removed ruff exceptions for files that no longer exist or no longer create formatting/linting errors in ruffTesting
running
make formaton this branch/PRIssue
fixes #30069