core[patch]: set version="v2" as default in astream_events #29894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:nit
eyurtsev
reviewed
Feb 19, 2025
| @@ -1057,9 +1060,11 @@ def with_parameters_and_callbacks(x: int, y: str, callbacks: Callbacks) -> dict: | |||
| """A tool that does nothing.""" | |||
| return {"x": x, "y": y} | |||
|
|
|||
| kwargs = {"version": "v2"} if specify_version else {} | |||
There was a problem hiding this comment.
feels like an unnecessary complication for this specific unit test
The test seems to boil down to confirming that the default version is v2
Perhaps a separate logical test for it would be good?
eyurtsev
approved these changes
Feb 19, 2025
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.