Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled a bug around empty query results differently #29877

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

am-kinetica
Copy link
Contributor

Thank you for contributing to LangChain!

  • Handled query records properly: "community: vectorstores/kinetica"

  • Bugfix for empty query results handling:

    • Description: checked for the number of records returned by a query before processing further
    • Issue: resulted in an AttributeError earlier which has now been fixed

@efriis

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 11:38am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Feb 19, 2025
@am-kinetica
Copy link
Contributor Author

@efriis - This is a bit urgent for us. Could you please help merge or let us know whether something needs to be done ? Thanks.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 20, 2025
@ccurme ccurme merged commit ca7eccb into langchain-ai:master Feb 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants