Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: allow passing JSON schema as args_schema to tools #29812

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

vbarda
Copy link
Contributor

@vbarda vbarda commented Feb 14, 2025

No description provided.

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 2:17pm

Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me! think we should add lots of tests

Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you update the branching logic so it's easy to reason about it and add a unit test?

@vbarda vbarda marked this pull request as ready for review February 18, 2025 14:22
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. langchain Related to the langchain package labels Feb 18, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 18, 2025
@eyurtsev eyurtsev merged commit d04fa1a into master Feb 18, 2025
71 checks passed
@eyurtsev eyurtsev deleted the vb/relax-args-schema branch February 18, 2025 19:44
rectalogic added a commit to rectalogic/langchain-mcp that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants