infra: migrate to uv #29566

ccurme · 2025-02-03T21:33:49Z

No description provided.

This reverts commit 7a8d558.

# Conflicts: # libs/community/extended_testing_deps.txt

zanieb · 2025-02-07T00:46:49Z

.github/workflows/_release.yml

-          poetry run pip install dist/*.whl
+          VIRTUAL_ENV=.venv uv pip install dist/*.whl


As a minor note, we should detect .venv as the target automatically here

e.g.

❯ uv venv Using CPython 3.12.6 Creating virtual environment at: .venv Activate with: source .venv/bin/activate ❯ uv pip install anyio Resolved 4 packages in 85ms Installed 4 packages in 4ms + anyio==4.8.0 + idna==3.10 + sniffio==1.3.1 + typing-extensions==4.12.2 ❯ ls .venv/lib/python3.12/site-packages __pycache__ anyio-4.8.0.dist-info sniffio-1.3.1.dist-info _virtualenv.pth idna typing_extensions-4.12.2.dist-info _virtualenv.py idna-3.10.dist-info typing_extensions.py anyio sniffio

Not that it's bad to be explicit — otherwise another VIRTUAL_ENV could overlap.

The following is also valid, if you prefer

uv pip install -p .venv ...

@ccurme weren't you running into some issues here where it was using some global context instead of the local install here, requiring the added environment variable specification?

I might be remembering wrong

I think astral-sh/setup-uv may activate a virtual environment by default, which would cause that behavior and be a bit annoying in this context — if that's the case I can look into changing that.

ref https://github.com/astral-sh/setup-uv/blob/f95cd8710c5064b4546350da1950efde82c26d24/src/setup-uv.ts#L148-L167

efriis

🤦‍♂️ didn't hit submit yesterday - will go through and resolve things we talked about async

efriis · 2025-02-04T22:36:59Z

.github/actions/uv_setup/action.yml

@@ -0,0 +1,23 @@
+# TODO: https://docs.astral.sh/uv/guides/integration/github/#caching


I assume this interacts ok with python-version but that would be main suspect if things go wrong with enable-cache: true

.github/scripts/check_diff.py

efriis · 2025-02-04T22:39:29Z

.github/scripts/check_diff.py

@@ -304,7 +307,7 @@ def _get_configs_for_multi_dirs(
                f"Unknown lib: {file}. check_diff.py likely needs "
                "an update for this new library!"
            )
-        elif file.startswith("docs/") or file in ["pyproject.toml", "poetry.lock"]: # docs or root poetry files
+        elif file.startswith("docs/") or file in ["pyproject.toml", "uv.lock"]: # docs or root uv files


might be worth adding a lint case that confirms there are no poetry.lock files in the tree

efriis · 2025-02-04T22:40:49Z

.github/scripts/check_prerelease_dependencies.py

+        dependencies = toml_data["project"]["dependencies"]
+        for dep_version in dependencies:


what changed here? why isn't it iterating over the keys anymore?

dependencies is no longer a dict matching dependency names to version constraints / markers etc. It is a list of dependency specifier strings.

efriis · 2025-02-04T22:44:33Z

.github/workflows/_lint.yml

@@ -87,21 +63,12 @@ jobs:
        if: ${{ ! startsWith(inputs.working-directory, 'libs/partners/') }}
        working-directory: ${{ inputs.working-directory }}
        run: |
-          poetry install --with test
+          uv sync --group test


technically I think this is a functional change because this will remove lint/typing deps, whereas poetry install (without --sync) would only add deps, and not remove anything

Updated in 06b99bd

.github/workflows/_release.yml

efriis · 2025-02-04T22:45:22Z

.github/workflows/_release.yml

@@ -184,13 +188,11 @@ jobs:
      # - The package is published, and it breaks on the missing dependency when
      #   used in the real world.

-      - name: Set up Python + Poetry ${{ env.POETRY_VERSION }}
-        uses: "./.github/actions/poetry_setup"
+      - name: Set up Python + uv


uv versioning maybe worth declaring - but assume different based on frozen thing

efriis · 2025-02-04T22:46:35Z

.github/workflows/_release.yml


      - name: Import test dependencies
-        run: poetry install --with test --no-root
+        run: uv sync --group test


This might reinstall the "current project" which we don't want - we want to install the built wheel we're testing. That's what --no-root was handling

happy to discuss this one

Indeed, you probably want uv sync --inexact --only-group test

But the subsequent step does say

Overwrite the local version of the package with the built version

which would replace it.

You probably want to skip the project dependencies regardless to ensure the wheel isn't missing declaration of any dependencies?

This workflow has

uv pip install dist/*.whl make tests <-- basically uv run --group test pytest ...

As I understand it the problem is that make tests will replace the wheel install with the local project.

In 8b8678f I set UV_NO_SYNC=true. Let me know if this isn't sufficient.

>>> uv pip install dist/*.whl >>> uv pip freeze | grep langchain langchain @ file:///.../libs/langchain/dist/langchain-0.3.18-py3-none-any.whl >>> make tests >>> uv pip freeze | grep langchain -e file:///Users/chestercurme/repos/langchain/libs/langchain

^ If I set UV_NO_SYNC=true, I get the wheel install in the second pip freeze.

efriis · 2025-02-07T00:48:28Z

.github/workflows/_release.yml

-          poetry run pip install dist/*.whl
+          VIRTUAL_ENV=.venv uv pip install dist/*.whl


@ccurme weren't you running into some issues here where it was using some global context instead of the local install here, requiring the added environment variable specification?

I might be remembering wrong

ccurme added 30 commits February 2, 2025 14:35

update

b07e6be

update core

f71cf38

remove tool.poetry

10f677f

core

4202c14

todo: delete tool.pdm.dev-dependencies

6693a0c

update

a1a6ef1

add action to setup uv and python

e034999

update get_min_versions script

b7bdf0b

update workflows

aa7637b

update check_diff script

070e12f

update

dcbedef

update scripts (todo: fix)

4dcc659

x

ea838e8

x

7013870

update get_min_versions

dfce027

x

1a4af62

x

c71fc8b

update dependency tests

e20603e

x

1a22baf

x

d6e2af4

lint

d9ce5f4

x

fb79799

x

cfa56be

add optional dependencies

3898048

test extras

7a8d558

update release workflows

bc24f60

increment version

e939cd4

Revert "test extras"

1c634f9

This reverts commit 7a8d558.

x

dd47b8c

x

fb4adb4

ccurme added 3 commits February 5, 2025 18:13

increment openai version

91fa2c3

increment anthropic version

88dca23

update api doc build workflow

5db6442

ccurme temporarily deployed to Scheduled testing February 5, 2025 23:24 — with GitHub Actions Inactive

ccurme temporarily deployed to Scheduled testing February 5, 2025 23:25 — with GitHub Actions Inactive

update api doc build workflow

13c6712

vercel bot deployed to Preview February 5, 2025 23:35 View deployment

ccurme added 3 commits February 5, 2025 21:14

x

a40db45

Merge branch 'master' into cc/migrate_uv

26a75d9

# Conflicts: # libs/community/extended_testing_deps.txt

increment langchain version

1dafe0e

vercel bot deployed to Preview February 6, 2025 13:22 View deployment

ccurme temporarily deployed to Scheduled testing February 6, 2025 13:27 — with GitHub Actions Inactive

ccurme added 2 commits February 6, 2025 08:33

update api doc build workflow

f0c24fd

x

77fad31

vercel bot deployed to Preview February 6, 2025 13:51 View deployment

ccurme added 2 commits February 6, 2025 08:54

x

e1c7c45

x

5b224c4

vercel bot deployed to Preview February 6, 2025 14:11 View deployment

delete poetry lock files

6751e15

vercel bot deployed to Preview February 6, 2025 14:32 View deployment

debug

542ed83

vercel bot deployed to Preview February 6, 2025 15:11 View deployment

ccurme added 2 commits February 6, 2025 10:16

x

e24da89

parse uv pyproject.toml in create_api_rst.py

2b17d6e

vercel bot deployed to Preview February 6, 2025 15:35 View deployment

ccurme merged commit d172984 into master Feb 6, 2025
284 of 285 checks passed

ccurme deleted the cc/migrate_uv branch February 6, 2025 18:36

zanieb reviewed Feb 7, 2025

View reviewed changes

efriis reviewed Feb 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infra: migrate to uv #29566

infra: migrate to uv #29566

ccurme commented Feb 3, 2025

zanieb Feb 7, 2025

efriis Feb 7, 2025

zanieb Feb 7, 2025 •

edited

Loading

efriis left a comment

efriis Feb 4, 2025

efriis Feb 4, 2025

efriis Feb 4, 2025

ccurme Feb 7, 2025

efriis Feb 4, 2025

ccurme Feb 7, 2025

efriis Feb 4, 2025

efriis Feb 4, 2025

zanieb Feb 7, 2025

zanieb Feb 7, 2025 •

edited

Loading

ccurme Feb 7, 2025

efriis Feb 7, 2025

		poetry run pip install dist/*.whl
		VIRTUAL_ENV=.venv uv pip install dist/*.whl

		@@ -0,0 +1,23 @@
		# TODO: https://docs.astral.sh/uv/guides/integration/github/#caching

		dependencies = toml_data["project"]["dependencies"]
		for dep_version in dependencies:

infra: migrate to uv #29566

infra: migrate to uv #29566

Conversation

ccurme commented Feb 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zanieb Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

efriis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zanieb Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zanieb Feb 7, 2025 •

edited

Loading

zanieb Feb 7, 2025 •

edited

Loading